Various compiler-driven code fixups

mikegashler / waffles

A toolkit of machine learning algorithms.

86 stars 33 forks source link

Various compiler-driven code fixups #10

Closed charlie-ht closed 8 years ago

charlie-ht commented 8 years ago

I started chasing down some memory leaks, but then realised my C++ compiler noticed several other issues which are also included in this PR.

charlie-ht commented 8 years ago

I do see the following, but I think it might be caused by improved analysis due to the const qualifier in optimizing value ranges.

$ test GBayesianModelAveraging
GBayesianModelAveraging                                               
accuracy has regressed. Expected at least 0.755. Only got 0.709. (Sometimes, harmless changes that affect random orderings can trigger small regressions, so don't panic yet.)

FAILED!!!

mikegashler commented 8 years ago

Thanks for the contributions! I really appreciate it.

That regressed unit test is strange. I don't see any changes could really affect accuracy, so I just lowered the bar for that test.