search

mikegashler / waffles

A toolkit of machine learning algorithms.
http://gashler.com/mike/waffles/
86 stars 33 forks source link

Compile problem on macOS #35

Closed wduminy closed 7 years ago

wduminy commented 7 years ago

I get a few errors like these while compiling (make install) on macOS Sierra, clang 800.0.42.1.

In file included from GActivation.cpp:27:
./GNeuralNet.h:228:7: error: 'step' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] 
void step(double learningRate, const GVec &gradient);`
mikegashler commented 7 years ago

My testing on macOS has been somewhat sporadic (because I don't have a Mac). I think I should remove "-Werror" from the compiler flags when the Makefile detects that it is using clang, so small issues like this don't create compile errors. I did that. Does this make the problem go away for you?

wduminy commented 7 years ago

I am new to the Mac, but maybe I can help you out a bit. The -Werror flag did work - we now get warnings instead of errors. The warnings are few enough to fix. I created a pull request