mikehadlow / gtr-cof

Interactive music theory dashboard for guitarists. http://guitardashboard.com/
MIT License
327 stars 64 forks source link

Roman numerals for major chords should be capitalised. #1

Closed mikehadlow closed 7 years ago

mikehadlow commented 7 years ago

Shouldn't the roman numerals show major or minor-ness of the note rather than the chord that with that root? For example, take A Dorian: A B C D E F# G C is the minor third note of the scale, but the C chord of this scale is a major: C E G. Since there's already a visual indication of the major or minor-ness of the chords, I'm going to go with the scale degree for the roman numerals.

mikehadlow commented 7 years ago

No Mike, the Roman numerals should show the major/minor-ness of the chord. This has now been changed.