search

mikehadlow / gtr-cof

Interactive music theory dashboard for guitarists. http://guitardashboard.com/
MIT License
327 stars 64 forks source link

Dots for violin/viola #24

Closed l3nz closed 3 years ago

l3nz commented 5 years ago

These places are where a beginner would put their fingers. They are usually "pasted on" with a sticker. I am not 100% positive for cello, but I guess it works the same way as a viola.

mikehadlow commented 5 years ago

Hi Lenz. Thanks for the PR, it's much appreciated. Just one addition please, you need to compile the TypeScript before committing. It's because GD is hosted on GitHub pages, so there's no build process.

l3nz commented 5 years ago

I though you'd want to do a compile after you accept a PR, so you are sure what gets run. Otherwise if you get two merges, maybe the compiled file is hard to manually merge.

mikehadlow commented 3 years ago

Manually merged this. Sorry it's taken so long, I got distracted and never came back :(