mikehadlow / gtr-cof

Interactive music theory dashboard for guitarists. http://guitardashboard.com/
MIT License
327 stars 66 forks source link

Chromatic circle improvements #35

Closed ibalashov closed 3 years ago

ibalashov commented 5 years ago
  1. Start on C at the top (this is more common than A, and aligns with wikipedia)
  2. Display chords on chromatic circle (maj, min, dim, etc.), with fretboard map (which comes automatically I guess).
mikehadlow commented 5 years ago

Thanks for this. I'm not quite sure what you mean by "Display chords on chromatic circle"? Chords are displayed there. Also "with fretboard map"? The chords displayed on the chromatic circle are also displayed on the fretboard.

I'm guessing this could be bug if you're not seeing the chords displayed. What device/OS/browser are you using?

ibalashov commented 5 years ago

Actually, I do see the chords, sorry to have mislead you. But it I need to watch the introductory video one more time :)

Also the positioning of the circles applies to both, not just to chromatic, just noticed.

mikehadlow commented 5 years ago

OK, no worries, thanks for the update. I think rather than just defaulting with the C at the top, which would be confusing for people who were already used to the existing default, how about having an option?

ibalashov commented 5 years ago

Yes, I agree.

mikehadlow commented 3 years ago

C is now at top centre by default (can switch back to A in settings)