search

mikehadlow / gtr-cof

Interactive music theory dashboard for guitarists. http://guitardashboard.com/
MIT License
327 stars 66 forks source link

Use GitHub Actions to build Typescript and publish site #61

Closed mikehadlow closed 3 years ago

mikehadlow commented 3 years ago

Done. gtr-cof.js and gtr-cof.js.map no longer maintained in source code.

peaceiris commented 3 years ago

I recommend you to remove package-lock.json from the .gitignore and add it under Git control for stable CI.

cf. https://docs.npmjs.com/cli/v6/configuring-npm/package-lock-json

After that, we can use npm ci instead of npm install. (Since npm ci does not resolve the dependency tree, it is faster than npm install)

mikehadlow commented 3 years ago

Thanks for that, really good advice.