search

mikehardy / react-native-update-apk

Update apk from non-play store servers, and update ios from app store in React Native.
MIT License
195 stars 57 forks source link

Added support for server oriented apps #22

Closed pilot4u closed 4 years ago

pilot4u commented 4 years ago

Added property apkVersionConfig which should contain {versionCode, forceUpdate, apkUrl} and will be provided externally instead of downloading this data from external file

mikehardy commented 4 years ago

Hi there @pilot4u ! Interesting, can you describe exactly how this would be used? I'm open to merging something - sure - but I would want a good description of the feature in the README plus some addition to the example app with an example version config to show it working, with comments explaining the action. In the end that is actually most of the work of a PR here but it also keeps support requests down because the example is so thorough

mikehardy commented 4 years ago

👋 no problem with AndroidX either (I wrote https://github.com/mikehardy/jetifier ;-) ), but this would also need to be documented and would be a breaking change so we'd do a major version bump if/when we release this

mikehardy commented 4 years ago

@pilot4u you have not responded to my comments. I will close this without further comment unless we can communicate