search

mikehardy / react-native-update-apk

Update apk from non-play store servers, and update ios from app store in React Native.
MIT License
195 stars 57 forks source link

ios getVersionError #29

Closed zhpeng8775 closed 4 years ago

zhpeng8775 commented 4 years ago

image

but my app store address is like "https://itunes.apple.com/cn/app/"，so getVersionError.

mikehardy commented 4 years ago

Hi there! Propose a PR that adds an optional (has a default value of the current URL) parameter for that API so you can override it, and I'll merge it in

mikehardy commented 4 years ago

(and worth noting - while you develop the PR and until it's merged you can use the excellent patch-package module to use your change in your project easily, so you are not blocked)

zhpeng8775 commented 4 years ago

image

I have fixed it like this. please review.

mikehardy commented 4 years ago

Ah that's even cleaner - that should work for all locations I think - have you tested a CN and a US app? If you propose this as a PR and confirm you have tested I can merge it in

mikehardy commented 4 years ago

Fixed in 4.4.0 thanks @jiapeng007