search

mikehardy / thunderlink

Link to your Thunderbird emails!
Mozilla Public License 2.0
42 stars 14 forks source link

MIME encoding of subject and from email address #27

Closed MarioKusek closed 5 years ago

MarioKusek commented 5 years ago

As discussed in pull request https://github.com/mikehardy/thunderlink/pull/26#issuecomment-450565792 this is new pull request that is using GlodaUtils.deMime function for email subject and for email author. This function is compliant to RFC 2047 and RFC 2231 and it is implemented in Thunderbird libraries.

As far as I understand Thunderbird code, it doesn't have support for RFC 6532. I think this is not problem because if RFC 6532 is needed the Thunderbird maintainers will put support in their libraries and Thunderlink will not need to change anything.

This pull request is based on PR https://github.com/mikehardy/thunderlink/pull/26

mikehardy commented 5 years ago

Thanks for separating this - I'm looking through #26 right now and after that's integrated I think this one will be really tiny / easy

MarioKusek commented 5 years ago

I forgot that I have also added another feature in this PR ;)

If I have in template \t or \n or \uXXXX it is converted to characters. This is done by calling JSON.parse("\"" + template + "\"");. I hope that this is OK.

mikehardy commented 5 years ago

I see it is in a separate commit so it's a little messy to put them all in one PR but there is a lot of code motion here, so I understand. This could use some documentation though - either in the preferences dialog or in the README or wiki or somewhere though - so if there's a problem we can point people somewhere...

mikehardy commented 5 years ago

Alright, now that #26 is merged, if you rebase and clean up - this one should be good to go, and I can do a real 1.2.7. Cheers :-)

MarioKusek commented 5 years ago

I have rebased #26 merge to master into this branch. Now it can be easily merged to master