search

mikehardy / thunderlink

Link to your Thunderbird emails!
Mozilla Public License 2.0
42 stars 14 forks source link

Thunderlink for selection of emails #32

Closed MarioKusek closed 5 years ago

MarioKusek commented 5 years ago

I have created implementation for #29

There is new preference that define selection delimiter which is then used for text in clipboard and in appending to file.

Please look at it.

mikehardy commented 5 years ago

You are a machine! :-) I may not get to this one for a couple days - but I just released 1.2.7 with all the previous changes, so it might be best as we let that settle in and see if anyone finds a bug before we push another change through

MarioKusek commented 5 years ago

Sure. No problem.

MarioKusek commented 5 years ago

I have created update as you suggested.

MarioKusek commented 5 years ago

When I integrated your changes for deprecation. I got errors. I have TB 60.4.0 and I got:

NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]

This is in thunderlinkModule.js:23

mikehardy commented 5 years ago

Oh no! I did the version limit wrong but it is close. I made the same change and error just. Now in a 2nd file then too. Can you rebase and reintegrate but change the check to 64 instead of 60 in both places? that should be correct

mikehardy commented 5 years ago

I just stepped away from the computer so it will be awhile otherwise

MarioKusek commented 5 years ago

Now it works. I have updated CHANGELOG as well.

mikehardy commented 5 years ago

Thanks so much @MarioKusek - this is a cool feature