mikehardy / thunderlink

Link to your Thunderbird emails!
Mozilla Public License 2.0
42 stars 14 forks source link

Add makefile and version file that can be used alongside build script #59

Closed nbeaver closed 4 years ago

nbeaver commented 4 years ago

The build script works fine, but I'm more familiar with makefiles. No hard feelings if you'd rather not use make.

mikehardy commented 4 years ago

Hmm - this one I don't like.

What I'd like to see is more of an expansion of the javascript work - a lint entry in scripts for instance, and a build entry in there that called the makeXpi.sh script that exists so the construction is defined in only one place

nbeaver commented 4 years ago

Fine by me.

mikehardy commented 4 years ago

Thanks for understanding. The old school coder in my likes how fast make is but it's 2020, we can't do anything now without it actually being completed by javascript (somehow!?!) and virtualized a minimum of 3 more times before hitting the metal. What a time to be alive.