search

mikehardy / thunderlink

Link to your Thunderbird emails!
Mozilla Public License 2.0
42 stars 14 forks source link

ThunderBird 60+ Compatibility (clicking links, creating links works, pref setting does not) #7

Closed gcamaril closed 5 years ago

gcamaril commented 6 years ago

Thunderlink is currently not compatible with TB 60+ and the new extensions policy.

avkhitry commented 6 years ago

Any chances this marvelous add on will rise from ashes?

mikehardy commented 6 years ago

This feature will rise from the ashes! As a True Developer I was being lazy since getting access to the ability to fix it, and my personal Thunderbird installation had not updated to 60 (I use Ubuntu 18.04)

But guess what, in the system updates I received recently my Thunderbird just went to 60 so now my personal workflow is disrupted and I need to get this working. I'm not the most skilled javascript developer yet so it may take a few days but I'll get it.

mikehardy commented 5 years ago

Today I became fully fed up with my broken workflow since the Ubuntu Thunderbird upgrade, and rolled up the sleeves.

We now have thunderlinks working in the sense you can create links by right-clicking in a message, and you can click links in your system and they will resolve to a message and the message will display again.

You have indicated by participating here that you are interested. I see no harm in trying this, so someone besides myself can provide feedback: https://github.com/mikehardy/thunderlink/releases/tag/1.2.2-beta2

Can you configure thunderlink via the preferenes? No. You can see preferences and type in the boxes but nothing is saved. That's next (and maybe very quickly). Because using the advanced config editor in normal usage is riciulous.

mikehardy commented 5 years ago

I still don't have preference saving working yet, but here's a good example of a project that has it working - https://github.com/tjeb/Mailbox-Alert/blob/720843b30792462d7281de6d6b8059fb1208405e/chrome/content/mailboxalert/alert_settings.xul

mikehardy commented 5 years ago

I just double-checked and in my normal email profile on Thunderbird it is still correctly creating links and displaying messages. Anyone else trying this? Would love to know if 1.2.2-beta2 is working for others as I prepare to tackle preference saving

avkhitry commented 5 years ago

Hi Mike! Just installed 1.2.2-beta2, sadly it does not works, not sure where is the bottomneck: (base) andrew@DaifuMain:~$ "/usr/lib/thunderbird/thunderbird" -thunderlink thunderlink://messageid=009101d4768f$d7cd3da0$8767b8e0$@synergycro.ru (thunderbird:7878): Gtk-WARNING **: 21:22:21.023: Theme parsing error: <data>:1:34: Expected ')' in color definition (thunderbird:7878): Gtk-WARNING **: 21:22:21.023: Theme parsing error: <data>:1:77: Expected ')' in color definition console.log: "thunderlink command with mailURL thunderlink://messageid=009101d4768f767b8e0synergycro.ru" console.log: "Unrecognized ThunderLink URL: thunderlink://messageid=009101d4768f767b8e0synergycro.ru"

Pop-up message says: Couldn't find an email message for ThunderLink thunderlink://messageid=009101d4768f767b8e0synergycro.ru It is Ubuntu 18.04.1 LTS, Thunderbird 60.2.1 (64-bit)

mikehardy commented 5 years ago

Hi @avkhitry - thanks for trying! Believe it or not, I think that's a positive sign. Thunderlink actually loaded (previously it would not even load on TB60), and it attempted to handle the email (previously it couldn't do that even after loading).

I have also seen this message in my testing and what it indicated to me was that the mail message simply didn't exist for whatever reason. It was correct too. Are you completely sure the email with that message id exists?

As a second test (since you already have it installed) - could you try right-clicking in a message window, making a new thunderlink and then trying to use it? If that fails as well then it's definitely a thunderlink bug. If that works, then I strongly suspect that the message just isn't there ?

avkhitry commented 5 years ago

Well, I created different links from existing mails by using right-click->Thunderlink-> local cmd option, so I`m pretty sure that these mails are exist. I tried different mails. Sadly, I was unable to test "pure thunderlink", without cmd options, because my attempts to register protocol still fruitless.

avkhitry commented 5 years ago

Here goes interesting thing: links of type "/usr/lib/thunderbird/thunderbird" -thunderlink thunderlink://messageid=SN6PR05MB4719DDA88716E8AFB9DD7662ECC10@SN6PR05MB4719.namprd05.prod.outlook.com and "/usr/lib/thunderbird/thunderbird" -thunderlink thunderlink://messageid=20181031140902.1.3F97408A12F2DE35@projecis.com are working well - open Thunderbird and switch to target mail. No errors here! But links of type "/usr/lib/thunderbird/thunderbird" -thunderlink thunderlink://messageid=000901d46c9d$f87576e0$e96064a0$@ru and "/usr/lib/thunderbird/thunderbird" -thunderlink thunderlink://messageid=00dc01d46c3f$afcf87e0$0f6e97a0$@synergycro.ru are not working at all, returning "Couldn't find an email message for ThunderLink" in one case it even opened wrong email - not that from thunderlink was created, but its "parent" (mail for which it was a reply): "/usr/lib/thunderbird/thunderbird" -thunderlink thunderlink://messageid=31512504-35c1-6175-58c8-0e665bfa5f48@synergycro.ru - opens my mail in "send", but was created from "inbox" mail.

mikehardy commented 5 years ago

Very interesting! Thanks again for testing, this information is great and it is very helpful

I may have just gotten lucky with the ones I've tested so far. I am a big fan of automated testing during development, and I could make a test out of your specific mails if I you are 100% that those messageids were created correctly - can you check the headers vs the links created on the ones that didn't work, and make sure the link was created correctly? I want to be sure which side had the error - link creation, or message-id resolution. Clearly at least one side has a problem...

avkhitry commented 5 years ago

I`ve checked couple of working and non-working links, in all cases Message-ID within source of email is identical to generated thunderlink, so, probably, its not link generation. Case with "pointing to the wrong mail" is probably not an issue, it is just my co-worker constantly adds two versions of my email into "To:" field, so when I reply I get a copy of my own sent mail in inbox, and these two mails (the one I send and the one I received) have identical message-ID in their source.

mikehardy commented 5 years ago

great, that helps, I'll try to poke the current code with some unit tests and the message ids that were failing to see what I can see.

tekvsakdan commented 5 years ago

First thank you for forking this Thunderbird add-on. I have tested with Ubuntu 18.10 and Thunderbird 60.2.1 and it is working fine with thunderlink:// or from the command line. I'm wondering is it possible to make it work if the Thunderbird is already opened.

jqueipoll commented 5 years ago

Its working for me. Even the old links work. I open the links from org-mode buffers in emacs (I create TODOs and link the corresponding mail to them)

By the way, thank you for your work. It's very useful for me.

Juan Queipo de Llano Moya

El 12/11/18 a las 17:55, Mike Hardy escribió:

I just double-checked and in my normal email profile on Thunderbird it is still correctly creating links and displaying messages. Anyone else trying this? Would love to know if 1.2.2-beta2 is working for others as I prepare to tackle preference saving

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mikehardy/thunderlink/issues/7#issuecomment-437953676, or mute the thread https://github.com/notifications/unsubscribe-auth/ALswMdaaziOnUlH0shTrIyQ2ps_BFG_aks5uuagRgaJpZM4W4Tsk.

mikehardy commented 5 years ago

@tekvsadan I'm not sure what you mean by Thunderbird already open, that is my main usage and it works for me? Can you open an issue with exact steps to reproduce what you get vs what you expect? Bonus points for a screen cast video link to YouTube to make sure I understand

And to all - thanks for checking it and reporting! You're welcome for the work, and maybe together we can make this wonderful little add on work really well again

mobileartur commented 5 years ago

I can report that 1.2.2.2 beta 2 works OK on my Windows 10 1803 17134.376 with Thunderbird 60.3.0 32bit. I created new links and checked also old ones. Everything works so far. I have the old registry mod and didn't change anything 0 just installed the new Thunderlink beta.

BTW: Thank you for this great add-on. I created my GitHub account because of this project! LOL! THX!

mikehardy commented 5 years ago

@mobileartur - thanks for the report, glad the basic use cases are working for you, that was my goal though it hasn't worked for everyone yet :-)

BTW: Thank you for this great add-on. I created my GitHub account because of this project! LOL! THX!

Master hacker status in your future, get to it! :-). Cheers

tekvsakdan commented 5 years ago

Let me explain again what bothers me. If Thunderbird is already open and if I click on thunderlink:// in a browser, it finds a message in a Thunderbird, but it doesn't open the message in a new tab. When Thunderbird is closed and if we click on thunderlink://, the Thunderbird opens only the message. The same command but 2 different results which depends if the Thunderbird is closed or open. Maybe I didn't correctly set the .desktop file or mimetype.

mikehardy commented 5 years ago

@tekvsakdan - ah I see. Thunderlink has different modes of operation - new tab, new message etc, set in the preferences. Perhaps whatever mode you have configured, in your installation, isn't functioning correctly?

For reference, I have the "preference name", extensions.thunderlink.open-tl-behaviour set to string type, value openInNewWindow and it works for me.

What's your setting? If you change it to openInNewWindow, does that improve things? If we can track this down, I can fix it as well

Thanks for the extra info

tekvsakdan commented 5 years ago

I have changed extensions.thunderlink.open-tl-behaviour to openInNewTab and it works as expected.

mikehardy commented 5 years ago

@tekvsakdan very happy to hear you are working now, but what was the prior value? Because it sounds like there is an error in handling whatever it was before and it would be good to know + fix it. Cheers

tekvsakdan commented 5 years ago

@mikehardy the prior value was bySelect or something. It is the default value.

mikehardy commented 5 years ago

Excellent - an error in handling the default value :man_facepalming: :-). Thanks again for the testing and the report.

Olifair commented 5 years ago

I would like to test, too. Thanks a lot mikehardy that you have been taking this up. mobileartur : how have you registered the protocol on windows 10 ? I have just switched to a new computer from windows 7 to 10 (as well as switching to the Thundrbird 60 with all the problems with most of the plugins I use ) and am not yet very firm on how to do things with windows 10. Thanks in advance for any tips you can give me.

mikehardy commented 5 years ago

@Olifair @mobileartur if there are any changes needed to the README.md file with respect to windows please let me know (or propose a PR, or make a wiki page? anything works for me) - I am on Ubuntu and Mac so I won't be able to help people with new windows instructions unfortunately

mobileartur commented 5 years ago

mobileartur : how have you registered the protocol on windows 10 ? I have just switched to a new computer from windows 7 to 10 (as well as switching to the Thundrbird 60 with all the problems with most of the plugins I use ) and am not yet very firm on how to do things with windows 10.

I use the same .reg file as for Windows 7 64 bit:

REGEDIT4
[HKEY_CLASSES_ROOT\thunderlink]
@="URL:thunderlink Protocol"
"URL Protocol"=""
[HKEY_CLASSES_ROOT\thunderlink\shell]
[HKEY_CLASSES_ROOT\thunderlink\shell\open]
[HKEY_CLASSES_ROOT\thunderlink\shell\open\command]
@=""C:\\Program Files (x86)\\Mozilla Thunderbird\\thunderbird.exe" -thunderlink "%1""

Create a file with .reg extension, copy the stuff between the dashes into it, changing the path to the thunderbird.exe if necessary, double-click on the file, confirm execution, done.

It works on Widows 10 64 bit with Thunderbird 32 bit. When you use Thunderbird 64 bit you have to change the path to "C:\Program Files\Mozilla Thunderbird\thunderbird.exe", but 64 bit version is not recommended on Windows. It can have some issues with other plugins and add-ons.

I updated the README.md with this info.

mikehardy commented 5 years ago

@mobileartur that's fantastic information and I'd love to have that added to / committed in the main repo but I don't see a pull request to alter it? I even looked in your local repo (where you'd make the change first before opening a pull request for me to merge in to the code here) and I didn't see a commit...

mobileartur commented 5 years ago

I can see it under "Your branches patch-1 Updated 34 minutes ago by mobileartur ". I created a pull request. Hmmm.... As I said this is my first time on Github as a participant. :D

mikehardy commented 5 years ago

Hmm - maybe github had a hiccup, anyway, I just saw it and merged it. First pull request? 🎊 🍾 :-)

mobileartur commented 5 years ago

@mikehardy Yeah! 🍾

Olifair commented 5 years ago

mobileartur I just tested the installation. Thunderlink installed Ok on my Thunderbird 60.3.0 32 bits on a windows 10 64 bit laptop. Then I put the proposed script with the registry values into a .reg and ran it. The registry values were created, except the '"command" one was empty and did not contain the ""C:\Program Files (x86)\Mozilla Thunderbird\thunderbird.exe" -thunderlink "%1"" I have tried to put it manually, trying different versions with our without the """ but when I click on the created thunderlink, I get an error that no application is linked to this protocol. any ideas ?

Olifair commented 5 years ago

mobilearthur : I solved the problem, I don't need the double backslashes "\" I need to put the following line into the command value : "C:\Program Files (x86)\Mozilla Thunderbird\thunderbird.exe" -thunderlink "%1"

Now it is working Great, I can go back using links from my Freeplane mind maps :-) I'm so happy

Oliver

mikehardy commented 5 years ago

Fixed with #22 - there will be a new release shortly, hopefully officially through the add-ons site so people get updates

There are still problems as submitted here (thanks everyone!) but I've created new issues for each of them. I don't believe there are "Thunderbird 60 Compatibility" issues anymore

mikehardy commented 5 years ago

They new version (1.2.3) is live on the official servers. If you've installed a test build here, maybe you could upgrade and just receive updates without effort on your part going forward? https://addons.thunderbird.net/en-US/thunderbird/addon/thunderlink/

A huge thanks to everyone for the feedback here. Knowing there were a few other souls out there interested in this kept me motivated to finish it. Enjoy the new build and I wish everyone increased productivity in the future ;-)

mikehardy commented 5 years ago

@simonthum - If I have found the correct person, you are the only other user I see on the Add-Ons stat board that appears to have a forked-but-working version of this add-on. You may be interested in going mainline again, joining the party here? Cheers

simonthum commented 5 years ago

Hi Mike - thanks for your efforts! ATM I honestly have no idea what to do about TL however. I am a happy user ;)