mikehenken / getsimple-blog

Blog system for Get-Simple CMS
5 stars 4 forks source link

content filter missuse #4

Closed tablatronix closed 12 years ago

tablatronix commented 12 years ago

Mike I think you are using content filters incorrectly.

You are using a content filter and then echoing out html.

Content filters are for modifying $content and returning it, not inline outputting.

This causes issues with anyone that uses getcontent() functions in their sites. It also breaks replacement plugins {% %}

Since you are using a slug replace method, you should be using. index-pretemplate

Then setting your html to global $content.

See my fork for example of fix. https://github.com/tablatronix/getsimple-blog/commit/a7e5ced8de791d4057e3f1805b6a2ea771a9e5eb

i am using output buffering to fix it, although its not ideal, ideally you build the content string and set it, but it works. I noticed you use this method in a few of your plugins, and it causes issues I mention in the commit.