search

mikehenrty / thin-pdo-wrapper

A simple database client utilizing PHP PDO.
MIT License
68 stars 32 forks source link

make connction string more generic #3

Closed eman1986 closed 11 years ago

eman1986 commented 11 years ago

The most glaring issue I see with this PDO class is that its hard coded to use MySQL.

The connection string portion should get rewritten so that any connection string supported by PDO will work instead of just one.

mikehenrty commented 11 years ago

Ah interesting. Out of curiosity, which of these drivers would you consider using thin-pdo for?

http://php.net/manual/en/pdo.drivers.php

eman1986 commented 11 years ago

I don't see why it couldn't be built to handle all of them. at the very least Postgresql, sqlite, and ms sql server.

mikehenrty commented 11 years ago

I agree, it would be a great feature to support all the PHP PDO drivers. I think postgres is especially useful. That said, unless you have a specific use case you are requesting support for, I sadly don't have the time to give this the attention it deserves. In the meantime though, I highly encourage you to contribute to this project! :)

eman1986 commented 11 years ago

I might just do that :)

mikehenrty commented 11 years ago

:+1:

eman1986 commented 11 years ago

I'm 90% done, the connection part has been written to accept any PDO driver, but SQL Server & Oracle I know from my experience with them handle limiting of records differently, so little stuff like that is my next task. :)

I'll keep you updated on my progress on this.

mikehenrty commented 11 years ago

Sounds great! I look forward to the pull request :)

On Mar 23, 2013, at 4:45 PM, eman1986 notifications@github.com wrote:

I'm 90% done, the connection part has been written to accept any PDO driver, but SQL Server & Oracle I know from my experience with them handle limiting of records differently, so little stuff like that is my next task. :)

I'll keep you updated on my progress on this.

— Reply to this email directly or view it on GitHub.

eman1986 commented 11 years ago

sent a pull request :)

there is technically a part two to this but this will at least provide multiple database engine support.