x is not a convenient name to be exported

mikeizbicki / HLearn

Homomorphic machine learning

Other

1.62k stars 135 forks source link

x is not a convenient name to be exported #16

Closed nh2 closed 11 years ago

nh2 commented 11 years ago

I have not seen Haskell code that does not call some variable x somewhere :P

This gives name shadowing or Ambiguous occurrence 'x' errors.

It is exported HLearn.Models.Classifiers (via HLearn.Models.Regression.PowerLaw, Coord record).

Maybe it could be called coordX?

I'm also not sure if HLearn.Models.Classifiers should re-export everything all the way down.

mikeizbicki commented 11 years ago

Haha whoops! I've renamed the Coord type now.

I prefer having files that reexport a lot just because it reduces the number of imports you need in client code. The only drawback I see (other than exporting a variable like x :) is potential for slower compilation times, but that doesn't seem to be an issue right now.