search

mikeizbicki / HLearn

Homomorphic machine learning
Other
1.63k stars 138 forks source link

Unnecessary Definition of HList and HVector? #26

Closed MattWis closed 10 years ago

MattWis commented 10 years ago

HLearn imports vector-heterogenous, which has an HList and HVector declaration. However, HLearn also defines HList and HVector within itself. Is there a reason for this, or can (/ should) I get rid of the internal implementations?

mikeizbicki commented 10 years ago

Hmm... I don't think anything actually uses the HVector or HList from vector-heterogenous anymore. There turned out to be better ways to do things. Those dependencies should probably be dropped.

The multivariate distributions still use the HLearn.Algebra.HList module, so we need to leave it in there for now. Eventually I'd like to redo that part, at which point it would make sense to drop HLists completely.