search

mikeizbicki / HLearn

Homomorphic machine learning
Other
1.62k stars 138 forks source link

Invalid subhask submodule #75

Open alexanderkjeldaas opened 8 years ago

alexanderkjeldaas commented 8 years ago

I can't clone master on this repository:

$ git clone --recursive https://github.com/mikeizbicki/HLearn
Cloning into 'HLearn'...
remote: Counting objects: 7143, done.
remote: Total 7143 (delta 0), reused 0 (delta 0), pack-reused 7143
Receiving objects: 100% (7143/7143), 16.56 MiB | 6.87 MiB/s, done.
Resolving deltas: 100% (3392/3392), done.
Checking connectivity... done.
Submodule 'datasets' (https://github.com/mikeizbicki/datasets.git) registered for path 'datasets'
Submodule 'subhask' (https://github.com/mikeizbicki/subhask.git) registered for path 'subhask'
Cloning into 'datasets'...
remote: Counting objects: 59507, done.
remote: Compressing objects: 100% (46412/46412), done.
remote: Total 59507 (delta 13085), reused 59507 (delta 13085), pack-reused 0
Receiving objects: 100% (59507/59507), 309.19 MiB | 26.63 MiB/s, done.
Resolving deltas: 100% (13085/13085), done.
Checking connectivity... done.
Submodule path 'datasets': checked out 'ea5a06d19c62de8bf28a43b2c948a011fd896fda'
Cloning into 'subhask'...
remote: Counting objects: 1492, done.
remote: Total 1492 (delta 0), reused 0 (delta 0), pack-reused 1492
Receiving objects: 100% (1492/1492), 723.94 KiB | 0 bytes/s, done.
Resolving deltas: 100% (910/910), done.
Checking connectivity... done.
fatal: reference is not a tree: 7cc8aaf689bfa99eabe1c71db55a8f1815d7eb24
Unable to checkout '7cc8aaf689bfa99eabe1c71db55a8f1815d7eb24' in submodule path 'subhask'
alexanderkjeldaas commented 8 years ago

I see #71 is related to this.

UnkindPartition commented 8 years ago

@mikeizbicki I'm also running into this. Could you fix it?

mikeizbicki commented 8 years ago

I've merged #71. Does that fix the problem?

UnkindPartition commented 8 years ago

Well, yes, but that set subhask to an old commit well behind master. Was that your intention?

Also, I just noticed that HLearn's stack.yaml refers to subhask on hackage, not a submodule. Is that your intention, i.e. are you continuing to maintain subhask on hackage rather than on github?

mikeizbicki commented 8 years ago

Well, yes, but that set subhask to an old commit well behind master. Was that your intention?

Yes. I often make updates to subhask without testing them on HLearn. The submodule referencing the old commit is so that I can track which version of subhask I know a particular version of HLearn will build with. It'll probably work with the latest commit from master, but I haven't actually tested it. (Actually in this case, I haven't personally tested the commit in the submodule because I just now took it from a pull request.)

Also, I just noticed that HLearn's stack.yaml refers to subhask on hackage, not a submodule. Is that your intention, i.e. are you continuing to maintain subhask on hackage rather than on github?

I honestly don't know anything about stack and don't use it personally. I just accepted that file as a pull request from someone who wanted to use stack. There is an old version of subhask on hackage, but the version that HLearn should be using is whatever commit the submodule points to.

UnkindPartition commented 8 years ago

There is an old version of subhask on hackage, but the version that HLearn should be using is whatever commit the submodule points to.

Gotcha. This is not the case at the moment, I'll send a pull request.