search

mikeizbicki / chajda

5 stars 1 forks source link

implemented augments_fasttext function #7

Closed joeybodoia closed 3 years ago

mikeizbicki commented 3 years ago

Thanks for squashing the commits. In the future, you'll want to adjust the commit so that it doesn't include all of the old commit messages, but just a 1 line summary of everything together.

It's almost ready for a merge, but there's a few minor issues I'd still like to get fixed first.

joeybodoia commented 3 years ago

Thanks for helpful comments Mike, I'll review them and make the necessary changes.

mikeizbicki commented 3 years ago

I still see 4 commits, so I don't think the squashing worked. Overall, the contents of the commits look fine, but I'll let you try resquashing again before I merge just so you can get more practice with that workflow.

joeybodoia commented 3 years ago

Sorry about that, I forgot to use git push --force. Should be only one commit now.

mikeizbicki commented 3 years ago

great job!