search

mikeizbicki / subhask

Type safe interface for working in subcategories of Hask
BSD 3-Clause "New" or "Revised" License
418 stars 43 forks source link

Add type signatures to some expressions in example2. #15

Closed cdepillabout closed 9 years ago

cdepillabout commented 9 years ago

When I'm going through Haskell tutorials, I appreciate when authors add in type annotations. It makes it much easier to look up confusing parts in the documentation. It also makes it so the reader doesn't have to follow along themselves in the repl.

However, adding type annotations makes the code a little "busier" and may draw away from the simplicity of the code.

mikeizbicki commented 9 years ago

Thanks!

I merged this into master instead of just dev. I also added a bit more documentation to clarify that the type signatures weren't mandatory.

cdepillabout commented 9 years ago

Okay sounds good!

I'm not sure when I should be submitting pull requests to master, and when I should be submitting pull requests to dev. Do you have some rule-of-thumb you go by?

mikeizbicki commented 9 years ago

New features/breaking changes into dev, documentation improvements into master.

cdepillabout commented 9 years ago

Okay, that sounds good. Thanks!