mikejgray / neon-homeassistant-skill

A Neon AI Skill for Home Assistant, which integrates with ovos-PHAL-plugin-homeassistant.
Apache License 2.0
7 stars 4 forks source link

Add some options to control "chattiness" of the plugin #40

Closed jumper047 closed 6 months ago

jumper047 commented 8 months ago

I added two options to your plugin:

Settings file example with new params:

{
    "verbose": false,
    "silent_entities": [
        "hallway lamp"
    ],
    "__mycroft_skill_firstrun": false,
    "connected": true
}

Fixes #34

jumper047 commented 8 months ago

Makes sense, thank you for feedback! Now it will be phrase or log entry. BTW, I changed and force-pushed commits, is it ok or is it better to add new commits with fixes?

mikejgray commented 8 months ago

Makes sense, thank you for feedback! Now it will be phrase or log entry. BTW, I changed and force-pushed commits, is it ok or is it better to add new commits with fixes?

Generally, I prefer new commits, as it makes it more clear what the history of the PR was. We squash commits on merge so there's no need to force-push anything