search

mikejgray / skill_easter_eggs

fun easter eggs for mycroft/ovos/neon
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

[BUG] "current start date" not picked up by the skill #2

Closed goldyfruit closed 1 year ago

goldyfruit commented 1 year ago

Description

When current startdate is asked, the skill is not able to pick-up the intent because the STT split-it as current start date.

Steps to Reproduce

Relevant Code

2023-05-05 11:38:01.038 - OVOS - ovos_utils.file_utils:resolve_resource_file:145 - WARNING - Expected a dict config and got None. This configfallback behavior will be deprecated in a future release
2023-05-05 11:38:01.082 - OVOS - ovos_dinkum_listener.__main__:_record_begin:285 - DEBUG - Record begin
2023-05-05 11:38:04.206 - OVOS - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:483 - DEBUG - transformers metadata: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills']}
2023-05-05 11:38:07.094 - OVOS - ovos_dinkum_listener.__main__:_save_stt:425 - INFO - Saving Utterance Recording
2023-05-05 11:38:07.104 - OVOS - ovos_dinkum_listener.__main__:_save_stt:445 - DEBUG - Wrote /home/ovos/.local/share/mycroft/listener/utterances/9d421382db3832eea435694ad85b8c24.wav
2023-05-05 11:38:07.109 - OVOS - ovos_dinkum_listener.__main__:_stt_text:410 - DEBUG - Record end
2023-05-05 11:38:07.145 - OVOS - ovos_dinkum_listener.__main__:_stt_text:422 - DEBUG - STT: current start date
2023-05-05 11:38:07.216 - skills - ovos_core.transformers:transform:63 - DEBUG - ovos-utterance-coref-normalizer: {'client_name': 'ovos_dinkum_listener', 'destination': ['skills'], 'filename': 'file:///home/ovos/.local/share/mycroft/listener/utterances/9d421382db3832eea435694ad85b8c24.wav', 'session': {'active_skills': [], 'context': {'frame_stack': [], 'timeout': 100998076020}, 'history': [['{"type": "recognizer_loop:record_end", "data": {}, "context": {"client_name": "ovos_dinkum_listener", "source": "audio", "destination": ["skills"], "transcription": "current start date", "filename": "file:///home/ovos/.local/share/mycroft/listener/utterances/9d421382db3832eea435694ad85b8c24.wav", "session": {"active_skills": [], "utterance_states": {}, "session_id": "1250f390-8309-4d76-bd75-b166f1d07fe5", "history": [], "lang": "en-us", "context": {"timeout": 100998076020, "frame_stack": []}}}}', 1683301087.111995]], 'lang': 'en-us', 'session_id': '1250f390-8309-4d76-bd75-b166f1d07fe5', 'utterance_states': {}}, 'source': 'audio', 'transcription': 'current start date', 'utterances': ['current start date'], 'lang': 'en-us'}
2023-05-05 11:38:07.222 - skills - ovos_core.transformers:transform:63 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'destination': ['skills'], 'filename': 'file:///home/ovos/.local/share/mycroft/listener/utterances/9d421382db3832eea435694ad85b8c24.wav', 'session': {'active_skills': [], 'context': {'frame_stack': [], 'timeout': 100998076020}, 'history': [['{"type": "recognizer_loop:record_end", "data": {}, "context": {"client_name": "ovos_dinkum_listener", "source": "audio", "destination": ["skills"], "transcription": "current start date", "filename": "file:///home/ovos/.local/share/mycroft/listener/utterances/9d421382db3832eea435694ad85b8c24.wav", "session": {"active_skills": [], "utterance_states": {}, "session_id": "1250f390-8309-4d76-bd75-b166f1d07fe5", "history": [], "lang": "en-us", "context": {"timeout": 100998076020, "frame_stack": []}}}}', 1683301087.111995]], 'lang': 'en-us', 'session_id': '1250f390-8309-4d76-bd75-b166f1d07fe5', 'utterance_states': {}}, 'source': 'audio', 'transcription': 'current start date', 'utterances': ['current start date'], 'lang': 'en-us'}
2023-05-05 11:38:07.227 - skills - ovos_core.intent_services:_handle_transformers:172 - DEBUG - utterances transformed: ['current start date', 'current start date'] -> ['current start date']
2023-05-05 11:38:07.467 - skills - ovos_core.intent_services.padatious_service:_match_level:90 - DEBUG - Padatious Matching confidence > 0.95
2023-05-05 11:38:07.511 - skills - ovos_core.intent_services.commonqa_service:handle_question:123 - INFO - Searching for current start date
2023-05-05 11:38:09.521 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:178 - INFO - Timeout occurred check responses
2023-05-05 11:38:09.531 - skills - ovos_core.intent_services.fallback_service:_fallback_range:171 - DEBUG - checking for FallbackSkillsV1
2023-05-05 11:38:09.614 - skills - ovos_workshop.skills.fallback:handler:117 - DEBUG - Checking fallbacks in range 0 - 5
2023-05-05 11:38:09.754 - skills - ovos_core.intent_services.fallback_service:_fallback_range:171 - DEBUG - checking for FallbackSkillsV1
2023-05-05 11:38:09.893 - skills - ovos_workshop.skills.fallback:handler:117 - DEBUG - Checking fallbacks in range 5 - 90

Other Notes

No response

mikejgray commented 1 year ago

@goldyfruit Is this because STT is turning it into start date instead of star date? The intent won't catch start

goldyfruit commented 1 year ago

@goldyfruit Is this because STT is turning it into start date instead of star date? The intent won't catch start

I think it's because the skill wants startdate and not start date (or maybe not).

mikejgray commented 1 year ago

@goldyfruit Is this because STT is turning it into start date instead of star date? The intent won't catch start

I think it's because the skill wants startdate and not start date (or maybe not).

https://github.com/mikejgray/skill_easter_eggs/blob/master/vocab/en-us/StardateKeyword.voc

star, not start, and it catches it with or without a space. I had some trouble getting it to capture from STT sometimes so it may be worth adding start date and startdate

goldyfruit commented 1 year ago

star, not start, and it catches it with or without a space. I had some trouble getting it to capture from STT sometimes so it may be worth adding start date and startdate

You are right!

mikejgray commented 1 year ago

Closing in favor of OVOS repo issue