[#31] Include Histograms in ScheduledReporter implementations

mikejihbe / metrics

A metrics library for Node.js

574 stars 58 forks source link

[#31] Include Histograms in ScheduledReporter implementations #38

Closed tolbertam closed 7 years ago

tolbertam commented 7 years ago

Fixes #31

ScheduledReporter implementations unintentionally omitted Histograms. This commit includes Histograms and refactors Timer code to utilize histogram reporting code since Timer contains a Histogram.

Also update CsvReporter to use a noop callback when calling fs.appendFile to avoid deprecation warning.

mikejihbe commented 7 years ago

Looks good! I'll merge it and push up a new version tomorow

tolbertam commented 7 years ago

merging per our discussion.