Fix type signature & add sanity check for type correctness

mikejihbe / metrics

A metrics library for Node.js

574 stars 58 forks source link

Fix type signature & add sanity check for type correctness #49

Closed pbadenski closed 6 years ago

pbadenski commented 6 years ago

Signature of ExponentiallyDecayingSample#update is reported as error by Typescript compiler. I also added typescript as dev dependency and "compilation" step to have a sanity check whether the type definition file compiles. (it would have caught this bug).

tolbertam commented 6 years ago

Excellent, thanks for adding the additional validation too, i didn't notice this until after i merged #50 which had a similar fix that i resolved conflicts for.

tolbertam commented 6 years ago

Released v0.1.14 with this fix, thanks!