search

mikejihbe / metrics

A metrics library for Node.js
574 stars 56 forks source link

Histogram.update optional timestamp in index.d.ts #52

Closed DeTeam closed 6 years ago

DeTeam commented 6 years ago

Adjust TS type declarations to reflect the reality for Histogram type: timestamp is optional.

DeTeam commented 6 years ago

Tests seem to t/o, not sure it's due to my changes or not 🤔

DeTeam commented 6 years ago

@mikejihbe could you please have a look/merge/help with travis?

DeTeam commented 6 years ago

@mikejihbe any chance you can have a look at it?

DeTeam commented 6 years ago

@tolbertam mb you could have a look? :)

tolbertam commented 6 years ago

@DeTeam apologies for the long delay, my email filters are all messed up. I'll take a look at this posthaste and if all looks good I can do a release.

tolbertam commented 6 years ago

Ah ok, yes this is super straightforward. I'll look into the travis failure (it's not related to this at all), and will do a release later today. Sorry again for the delay!