search

mikejihbe / metrics

A metrics library for Node.js
574 stars 56 forks source link

Missing parameters in the constructor to connect to graphite server #73

Open hzwlille opened 2 years ago

hzwlille commented 2 years ago

https://github.com/mikejihbe/metrics/blob/0e00364f0dd577bb8db0e8fc0e93f88ec41f6324/index.d.ts#L170

It seems that when I tried to use it with TypeScript to send to graphite server, I would need parameters for server connection.

this.reporter = new GraphiteReporter(this.report, this.getPrefix(), this.address, this.port);



https://github.com/mikejihbe/metrics/blob/0e00364f0dd577bb8db0e8fc0e93f88ec41f6324/reporting/graphite-reporter.js#L17

Should this be changed?
hzwlille commented 2 years ago

https://github.com/mikejihbe/metrics/pull/74