search

mikejohnson51 / climateR

An R 📦 for getting point and gridded climate data by AOI
https://mikejohnson51.github.io/climateR/
MIT License
168 stars 40 forks source link

'aoiProj' is not an exported object from 'namespace:AOI' #14

Closed AntoineCabon closed 4 years ago

AntoineCabon commented 4 years ago

Hi Mike,

Thanks for that useful package. When running the example code chunk:

ts = geocode('Colorado Springs') %>% 
  getLOCA(param = 'tmax', model = 10, startDate = "2030-01-01", endDate = "2040-12-31")

I get: 'aoiProj' is not an exported object from 'namespace:AOI'

Do you have a fix?

Thanks Antoine

mikejohnson51 commented 4 years ago

Hi Antoine,

Thank you! This was a test I had not looked at after fixing some issues with AOI.

e573217 should fix this and the following works:

AOI = AOI::geocode('Colorado Springs') %>% 
  getLOCA(param = 'tmax', model = 10, startDate = "2030-01-01", endDate = "2030-01-01") %>% 
  tidyr::pivot_longer(-c(source, lat, lon, date))

Beware, the request you have above will take some time (~36525) values. For me it took 51 seconds.

Any feedback on your use case would be welcome!

Thanks again,

Mike

AntoineCabon commented 4 years ago

Hi Mike,

The fix is working for me, thanks!

So, I am actually using your package to compare performance and accuracy with some homemade scripts, which are not perfect to see if I might switch to your code.

Best, Antoine