mikekazakov / nimble-commander

Nimble Commander - dual-pane file manager for Mac
https://magnumbytes.com/
GNU General Public License v3.0
343 stars 34 forks source link

[UI]: Number of found items in search bar could benefit from padding. #399

Closed teropentis64 closed 1 month ago

teropentis64 commented 1 month ago

Confirmation

Version of Nimble Commander

Nightly Build #250, macOS 15.0

Current Appearance

befo

Expected Appearance

after

Additional Information

Readability of number of found items when searching in current folder could benefit from few pixels padding. I've moved the number left by 10px so the space between "x" circle is the same. The number is also a bit darker (not here though, on Expected Appearance screenshot) closeup

mikekazakov commented 1 month ago

Agree, it should be a nice refinement.

The gap can be adjusted here: https://github.com/mikekazakov/nimble-commander/blob/625c67ddc1f5866af8d8fdad3287e97fa8d6b09d/Source/NimbleCommander/NimbleCommander/States/FilePanels/PanelViewHeader.mm#L205

The font colour can be adjusted hereL https://github.com/mikekazakov/nimble-commander/blob/625c67ddc1f5866af8d8fdad3287e97fa8d6b09d/Source/NimbleCommander/NimbleCommander/States/FilePanels/PanelViewHeader.mm#L88

teropentis64 commented 1 month ago

Ok, I've set it to:

[self addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"[m_SearchMatchesField(==50)]-(25)-|"

and

m_SearchMatchesField.textColor = [NSColor systemGrayColor];

the result is: result

mikekazakov commented 1 month ago

Thank you. How does it look in the Dark mode? The (relatively) fixed colours might be a bit problematic as they do not "invert" when the appearance changes. For the grey colour it might be less relevant, but still.

teropentis64 commented 1 month ago

Good catch, I forgot to check. Seems to be ok.

darkk

mikekazakov commented 1 month ago

Done, thanks!