search

mikekelly / hal-browser

An API browser for the hal+json media type
MIT License
835 stars 157 forks source link

Why is .gitignore excluding html files #96

Closed arichiardi closed 6 years ago

arichiardi commented 6 years ago

Hello folks,

I was trying to use this package along with another couple of our things and I have noticed that npm did not include the two files browser.html and login.html in the deployed version. I then came here and noticed that they are excluded by .gitignore and unfortunately npm does consider that when deploying.

So what I wanted to ask really is whether we could remove the line from .gitignore or (more likely) there is a super valid reason not to do so :smile:.

Thanks for this package @mikekelly, it is super useful!

arichiardi commented 6 years ago

Hello! Any suggestion on how to solve this?

arichiardi commented 6 years ago

I solved by explicitely using the files key in my package.json.