mikel / mail

A Really Ruby Mail Library
MIT License
3.6k stars 931 forks source link

Solve warnings #1597

Closed eval closed 1 month ago

eval commented 6 months ago

Fixes #1384, #1424, #1572

Before: https://github.com/mikel/mail/actions/runs/7384712114/job/20088103249#step:5:8

sebbASF commented 6 months ago

Given that these mostly come from generated files, it might be better to just ignore them as suggested here:

https://dev.to/qortex/ruby-suppress-those-warnings-you-can-t-do-anything-about-6ie

eval commented 6 months ago

While an easy option (for us), I think it's better in this case to not ship a transitive dependency for downstream users. Something the most popular gems using warning-gem also don't seem to do (ie it's a development dependency).

skipkayhil commented 6 months ago

This looks like an incomplete version of #1551. All of those parser files are generated by rake ragel, so modifying them by hand is not a good idea in my opinion.

eval commented 1 month ago

All of those parser files are generated by rake ragel, so modifying them by hand is not a good idea in my opinion.

@skipkayhil you're right, closing this one.