search

mikelambert / react-native-fabric-crashlytics

Implements crash reporting on top of react-native-fabric library.
ISC License
114 stars 21 forks source link

addressing https://github.com/mikelambert/react-native-fabric-crashly… #3

Open jondot opened 8 years ago

jondot commented 8 years ago

…tics/issues/1

arronmabrey commented 8 years ago

Here is a working link to the issue this PR addresses https://github.com/mikelambert/react-native-fabric-crashlytics/issues/1

sibelius commented 7 years ago

@mikelambert any progress on this?

kyle-ssg commented 7 years ago

@jondot did you manage to get this working on android? If so what did you set --sourcemap-output to and what path did you look at with RNFS ? I notice that on android ${RNFS.MainBundlePath} is undefined

Other than that it works great on ios, huge improvement

reyalpsirc commented 7 years ago

@kyle-ssg Check if my pull request fits your needs.

mikelambert commented 7 years ago

Ugh I am guilty for leaving this lagging (if I'm reading #1 correctly). I am curious if @jondot and @reyalpsirc can coordinate to see if you both would prefer one approach versus the other. Or in the absence of agreement, a breakdown of the pros/cons of each approach would be nice.

I'm really sorry that I'm the lagging maintainer of this, given that I'm not really using this for stacktraces anymore, since moving to Sentry. If either of you are interested in becoming a committer for any future work, I'd be happy to hand it over, too.