Closed wkozaczuk closed 7 years ago
@wkozaczuk thanks for the contribution. I'm merging this PR without really testing it since we're currently focusing only on qemu
when using capstan package compose
. I've just opened an issue about this, to remind me that we should support other hypervisors as well.
Actually this change benefits when one runs an image composed by capstan like so:
capstan run -c 2 -v -p vbox
On Thu, Oct 19, 2017 at 10:24 AM, Miha Pleško notifications@github.com wrote:
Merged #67 https://github.com/mikelangelo-project/capstan/pull/67.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mikelangelo-project/capstan/pull/67#event-1301191381, or mute the thread https://github.com/notifications/unsubscribe-auth/AFDSIe3x5G2keDB26olDkUURAr_PZqedks5st1uqgaJpZM4P_FiB .
May I ask how do you compose the image that is runnable on vbox? I always use capstan package compose <image>
, and if I then run it like this capstan run -p vbox <image>
then it complains that there is no such image...
I simply convert qemu image using qemu-img like so:
qemu-img convert -O vdi ~/.capstan/repository/app/app.qemu ~/.capstan/repository/app/app.vbox
That is enough to make it runnable under VirtualBox.
On Thu, Oct 19, 2017 at 11:17 AM, Miha Pleško notifications@github.com wrote:
May I ask how do you compose the image that is runnable on vbox? I always use capstan package compose
, and if I then run it like this capstan run -p vbox then it complains that there is no such image... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mikelangelo-project/capstan/pull/67#issuecomment-337941061, or mute the thread https://github.com/notifications/unsubscribe-auth/AFDSIXUY0aOtDBbFhNxVrg2ml2ik1AHwks5st2f4gaJpZM4P_FiB .
Oh, I didn't realize it's that simple 😄 That just yet another reason why Capstan should be able to do it automatically so users needn't get their hands dirty. Thanks @wkozaczuk !
Changed hypervisor/vbox/vbox.go by adding "--hostiocache on" option to storagectl to improve storage performance under VirtualBox. Please see http://underpop.online.fr/v/virtualbox/ch05s07.html for details.
Signed-off-by: Waldemar Kozaczuk jwkozaczuk@gmail.com