search

mikelangelo-project / osv-microservice-demo

Simple Node.js Microservice application use to demonstrate the use of OSv and Capstan
13 stars 1 forks source link

Allow keyvaluestore.js to set endpoints from environment #5

Closed miha-plesko closed 7 years ago

miha-plesko commented 7 years ago

When running on Kubernetes, service endpoints will be known upfront since we will be calling them by name. So we support setting them by the means of environment variables in this commit. We also provide a meta/run.yaml.

miha-plesko commented 7 years ago

NOTE: Once Virtlet implements support for environment variables (thru cloud-init) it will no longer make sense to hardcode them here in meta/run.yaml because we will provide them in Kubernetes yaml. Until then, this seems reasonable enough especially since they are static.

miha-plesko commented 7 years ago

I will update the Node version and wait for https://github.com/mikelangelo-project/osv-microservice-demo/pull/6 to get merged, then we can merge this one.