Closed miha-plesko closed 7 years ago
@gberginc I'm asking upfront since I'm not sure if we should hack it like this or should we go into using cloud-init by Capstan and passing environment variables there.
One of the things we've discussed in the past is how we should handle "run config options". I think this is one of the cases where this would be handy. Your proposal to expose --env
as a separate cmd option that is then built into the run command is reasonable as we should not bother users with having to know that runscript
OSv loader command exists at all.
The alternative that I see is that we use some sort of template variables (not sure, but perhaps {IP}
in this example is something like this?). This would then construct the run command script with placeholders that could be replaced in the runtime, however I don't think there are real benefits over the env variables.
I've removed [WIP] prefix from this PR since it is safe to merge it as it is.
While trying to provide
meta/run.yaml
to run this application I've encountered an annoying problem: keyvaluestore endpoint is not known on build time. So I would like to discuss how should we proceed. What one can do at the moment is:What I'm thinking is that we should upgrade Capstan to be able to generate command with env variable:
What do you think?