search

mikelax / forgingadventures

0 stars 0 forks source link

chore: get build working for client. #192

Open mikelax opened 6 years ago

mikelax commented 6 years ago

This is a WIP. It's been a while since looking at the fa client, but I could not get a docker build or even with yarn build to work unless I made this change in the webpack config to comment out the eslint plugin. You'll notice I even needed to make a change to the Dockerfile to get it to build???

I tried comparing to the DS client project and webbpack configs and I can't notice any differences. Any ideas?

The goal for this change is to explore taking the client build and publishing it to netlify to eliminate all the docker resources, config, etc for the client app. Should simplify (and reduce cost) a bunch.

mikelax commented 6 years ago

@nazar still a WIP for netlify but I have a preview site working, obviously not hooked up to an api yet.

mikelax commented 6 years ago

@nazar I took another look at the webpack prod configs between DS and FA, and I noticed one difference is with the stylus loaders. In DS we have a single test command, and also one uses rupture vs. jeet. I tried to update FA to use a single loader with rupture but I was getting a different error, I think before it even got to the uglifyjs portion. I know DS doesn't use semantic ui, but I 🤷‍♂️ 

Failed to compile.

./node_modules/semantic-ui-css/semantic.min.css
Module build failed: ModuleBuildError: Module build failed: ParseError: /Users/mike/git/mikelax/forgingadventures/client/node_modules/semantic-ui-css/semantic.min.css:27:4940
nazar commented 5 years ago

Failed to compile.

./node_modules/semantic-ui-css/semantic.min.css Module build failed: ModuleBuildError: Module build failed: ParseError: /Users/mike/git/mikelax/forgingadventures/client/node_modules/semantic-ui-css/semantic.min.css:27:4940

Hmmm... I'm not seeing this on my newly built dev containers. Is this from yarn build inside a container or on the host?