search

mikelolasagasti / revelation

Revelation is a password manager for the GNOME desktop, released under the GNU GPL license. It stores all your accounts and passwords in a single, secure place, and gives you access to it through a user-friendly graphical interface.
https://revelation.olasagasti.info
GNU General Public License v2.0
55 stars 24 forks source link

Consistent Stack Track #21

Closed mhmoran closed 4 years ago

mhmoran commented 4 years ago

658 items in the store. Divided into folders based on usage, 95% are passwords for websites, the remaining 5% are credit card info.

My entry for my Github credentials, causes the following stack trace EVERY time. It doesn't matter if I try it right after opening revelation or if I've been using it for awhile.

Any chance, that this is related the contents of the password? I haven't found another entry that will generate said stack trace, but once I trip the stack trace, everyone after it will generate the stack trace if I continue.

Traceback (most recent call last): File "/usr/local/bin/revelation", line 774, in cb_tree_doubleclick self.entry_goto((iter,)) File "/usr/local/bin/revelation", line 1349, in entry_goto util.execute_child(command) File "/usr/local/lib/python3.8/site-packages/revelation/util.py", line 184, in execute_child items = shlex.split(command.encode("iso-8859-1"), 0) File "/usr/lib/python3.8/shlex.py", line 311, in split return list(lex) File "/usr/lib/python3.8/shlex.py", line 300, in next__ token = self.get_token() File "/usr/lib/python3.8/shlex.py", line 109, in get_token raw = self.read_token() File "/usr/lib/python3.8/shlex.py", line 140, in read_token nextchar = self.instream.read(1) AttributeError: 'bytes' object has no attribute 'read'

Anything else I can provide to help ?

gbm19 commented 4 years ago

Attached patch may solve the issue. issue-21.patch.txt

mikelolasagasti commented 4 years ago

Thanks @gbm19 !

@mhmoran I've tested the patch and is working correctly. You can change manually the file if you require or build from master again. I'll release 0.5.1 this week with this fix.