search

mikemaccana / io-2012-slides

Automatically exported from code.google.com/p/io-2012-slides
0 stars 1 forks source link

iframe load/unload needs to work correctly #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Moving back slides (left) doesn't unload them properly.

We always do:
window.setTimeout(this.disableSlideFrames_.bind(this, curSlide - 2), 301);

  this.enableSlideFrames_(curSlide - 1);
  this.enableSlideFrames_(curSlide + 1);
  this.enableSlideFrames_(curSlide + 2);

The first line won't work correctly if you're moving left.

Original issue reported on code.google.com by ebi...@gmail.com on 10 Apr 2012 at 10:23

GoogleCodeExporter commented 8 years ago 
We're no longer disabling/unloading iframes, but the loading works correctly.
It loads the next slide's iframe after a small amount of time to prevent jank
from the css transtions.

Original comment by ebi...@gmail.com on 22 Apr 2012 at 6:30