mikemaccana / outdated-browser-rework

Detects outdated browsers and advises users to upgrade to a new version. Handles mobile devices!
MIT License
226 stars 63 forks source link

Close button issue. #33

Closed jpoles1 closed 6 years ago

jpoles1 commented 6 years ago

image

Close button appears incorrectly. Had to change the character in the JS file at my line 183:

return "<h6>" + messages.outOfDate + "</h6>" + updateMessage + '<p class="last"><a href="#" id="buttonCloseUpdateBrowser" title="' + messages.close + '">x</a></p>'

Also had to update the class definition to:

#outdated .last {
    height: 20px;
    position: absolute;
    right: 70px;
    top: 10px;
    width: auto;
    display: inline-table;
}
mikemaccana commented 6 years ago

Want to send a PR?

On Wed, 6 Jun 2018 at 16:29, Jordan Poles notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/366282/41048403-a053e222-697c-11e8-802e-b736aeabead6.png

Close button appears incorrectly. Had to change the character in the JS file at my line 183:

return "

" + messages.outOfDate + "
" + updateMessage + '

x

'

Also had to update the class definition to:

outdated .last {

height: 20px;
position: absolute;
right: 70px;
top: 10px;
width: auto;
display: inline-table;

}

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mikemaccana/outdated-browser-rework/issues/33, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKiMlqI0hgCUG3KkTXu-w6uxLzRJV2Wks5t5_VPgaJpZM4Uc34d .

jpoles1 commented 6 years ago

Sure, will do! Thanks for developing this great code!

jpoles1 commented 6 years ago

Fixed by #35