NodeMon for Rebuilding - Githubissues

mikemaccana / outdated-browser-rework

Detects outdated browsers and advises users to upgrade to a new version. Handles mobile devices!

MIT License

226 stars 63 forks source link

NodeMon for Rebuilding #44

Closed jpoles1 closed 6 years ago

jpoles1 commented 6 years ago

I find gulp to be a bit overly complex for building this project. I've added a command for watching the source files for changes and rebuilding. It can be run via:

npm run watch

mikemaccana commented 6 years ago

Cool and thanks! Two tiny bits of feedback:

Please separate out your PRs - that way if the mobile has a problem, but the npm run watch was great, we could revert one and keep the other.
Don't bother explaining what the code does if it's obvious - this keeps the codebase interesting and means comments where they're used are actually needed.

var fullscreen = options.fullscreen || false; //Defaulting fullscreen to false.

But yes, this is a good idea. I might even remove gulp completely, as npm scripts are getting more popular these days.