search

mikemaccana / outdated-browser-rework

Detects outdated browsers and advises users to upgrade to a new version. Handles mobile devices!
MIT License
226 stars 63 forks source link

Detects Ubuntu Chromium as out of date. #49

Closed Asday closed 6 years ago

Asday commented 6 years ago

image

https://chromium.woolyss.com/ tells me that my version is in fact rather new.

Is this some issue with the library not knowing what Chromium is?

Huulivoide commented 6 years ago

@Asday What is the user agent Ubuntu's/Mint's Chromium has? Chromium should have exactly the same user agent as Chrome, but maybe it can be overridden while building the browser from source and Ubuntu/Mint decided to so.

Huulivoide commented 6 years ago

Found one online. Indeed it seems Ubuntu modifies the user agent and ua-parser-js then reports it as Chromium instead of Chrome.

mikemaccana commented 6 years ago

@Huulivoide What's the actual string? Can you test it on https://faisalman.github.io/ua-parser-js/, maybe we just need to update ua-parser-js.

mikemaccana commented 6 years ago

OK it's Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/69.0.3497.81 Chrome/69.0.3497.81 Safari/537.36 which works according to https://faisalman.github.io/ua-parser-js/ I'm going to update UA parser and publish.

@asday can I confirm you have Chromium listed as a supported browser?

mikemaccana commented 6 years ago

Hrm we're already using the newest version of US parser , that detects Chromium. I suspect this may be user error - Chromium not specified as supported

Asday commented 6 years ago

I would argue with the idea that this is my error. I have an up to date widely used browser, and the library is telling me it's out of date. If it doesn't support Chromium detection, then that's a missing feature, not user error.

mikemaccana commented 6 years ago

Chromium isn't a widely used browser, but this library supports Chromium if you turn it on. I'm trying to help you by asking you if you turned it on per the README: it would be good if you could reply.

On Fri, 26 Oct 2018 at 1:04 am, Asday notifications@github.com wrote:

I would argue with the idea that this is my error. I have an up to date widely used browser, and the library is telling me it's out of date. If it doesn't support Chromium detection, then that's a missing feature, not user error.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mikemaccana/outdated-browser-rework/issues/49#issuecomment-433244650, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKiMnTokl85CsWjW0ZzSM7juWbSl9QIks5uolGcgaJpZM4XdY2I .

Asday commented 6 years ago

Apologies, I misread your comment. It certainly isn't in the options of the project I noticed the issue on. I'll raise the issue with them.

Much appreciated.

mikemaccana commented 6 years ago

It's cool, you're welcome to send a PR for the README clarifying anything thats vague, or t the defaults adding Chromium.

On Fri, 26 Oct 2018 at 4:21 am, Asday notifications@github.com wrote:

Apologies, I misread your comment. It certainly isn't in the options of the project I noticed the issue on. I'll raise the issue with them.

Much appreciated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mikemaccana/outdated-browser-rework/issues/49#issuecomment-433273777, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKiMlXp88WtOaopIgrsrllkS5aVxmsjks5uon-fgaJpZM4XdY2I .