search

mikemaccana / outdated-browser-rework

Detects outdated browsers and advises users to upgrade to a new version. Handles mobile devices!
MIT License
226 stars 63 forks source link

Improvements #50

Closed Huulivoide closed 6 years ago

Huulivoide commented 6 years ago

The first commit fixes bugs #41 and #36. It should also make this compatible with pre ES5 browsers. node-deep-extend was pulling in all sorts of crap and using ES5 features → Repalced with a more simple custom implementation that is sufficient for our needs.

Removing node-deep-extend made the bundle ~35KB smaller.

The second commit cleans up away the unused gulp bits and and enables some UglifyJS options that will help saving 5 more KBs on the bundle.

mikemaccana commented 6 years ago

Thanks. Can you add the generated files to /dist?

I personally hate committing generated files but people are lazy and keep asking for them.

Huulivoide commented 6 years ago

Both commits should have generated files in dist.

[c076bd8a3230d1ee14d990e64ca64ed171feebdc]: dist/oldbrowser.js & dist/outdated-browser-rework.min.js are the same minified file. [c75645840ba133538568e8a2669882c79cdfa18a]: dist/outdated-browser-rework.js (unminified) & dist/outdated-browser-rework.min.js (minified). dist/oldbrowser.js removed.

mikemaccana commented 6 years ago

Thanks! I'll publish a new minor version with this goodness now.

mikemaccana commented 6 years ago

Currently blocked on https://github.com/npm/npm/issues/17997

mikemaccana commented 6 years ago

Worked around by using yarn publish instead of npm

mikemaccana commented 6 years ago

This is now in 2.6.0