search

mikemaccana / whois-json

Whois with results in actual, structured, camelCased JavaScript!
61 stars 34 forks source link

Domain Whois : information is on multiple lines #25

Open sachinraste opened 4 years ago

sachinraste commented 4 years ago

Issue 1 : Test Case : aud.edu Explanation : While parsing the data , the parser encounters "registrant:", since the data is residing on multiple lines and since ":" is the last character, "registrant" key is not added to the result object.

Issue 2 : Test Case : walmart.com Explanation : Test is available in tests.js. However parse-raw-data.js hasnt yet been adapted to handle this data.

modifications : parse-raw-data.js Added BLOCKSTART and BLOCKEND to handle multiple records while doing IP Whois Added REGEX to find ": " Added results.record Array, to hold multiple results served by IP Whois

modification : tests.js Added the test for aud.edu

Repository : sachinraste/whois-json

Kindly review the code and if acceptable , PR would be sent.

mikemaccana commented 4 years ago

Heya - good spots! Just send the PR, that's where you do code reviews on GitHub!