search

mikemalinowski / qute

A Qt helper library extending Marcus Ottosson's Qt.py library
MIT License
12 stars 3 forks source link

Preference: Forced argument of size on CopyToClipboardButton feels potentially unnecessary? #9

Open ldunham1 opened 4 years ago

ldunham1 commented 4 years ago

https://github.com/mikemalinowski/qute/blob/3c5e1c34eba7153ba564910963f5c48c7abd1b4c/qute/extensions/buttons.py#L11

Personally, I let the layout constraints and affecting size policies do there thing, only setting the size if I need to. Forcing a size argument feels a little unnecessary outside of the button's existing usage?

mikemalinowski commented 4 years ago

Exposed as an argument so it can be overridden. I do wonder whether it should be an argument at all though. I will probably put together some general standards/expectations for flexibility of 'extended widgets'

ldunham1 commented 4 years ago

Exposing as an argument make sense, but IMO it should have a default value of None to use either a size suitable to the intended usage or just not used (devs and modify after anyway)

mikemalinowski commented 4 years ago

Yes, i agree actually. I will re-open this