search

mikemccand / chromium-compact-language-detector

Automatically exported from code.google.com/p/chromium-compact-language-detector
160 stars 31 forks source link

Python bindings do not work with python-3 #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.
python3 setup.py
  File "setup.py", line 21
    if error <> '':
              ^
SyntaxError: invalid syntax

2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.
It is clear that setup.py in not python3-friendly.

Please port python bindings to python-3.X.

Original issue reported on code.google.com by trtrmi...@gmail.com on 8 Feb 2013 at 10:45

GoogleCodeExporter commented 9 years ago 
I just pushed fixes for this; can you try again?

Original comment by luc...@mikemccandless.com on 8 Feb 2013 at 11:08

GoogleCodeExporter commented 9 years ago 
If I don't have cld library installed, setup.py returns an exception:

Traceback (most recent call last):
  File "setup.py", line 22, in <module>
    sys.stderr.write('`pkg-config --libs --cflags cld` returns in error: \n' + error + '\n')
TypeError: Can't convert 'bytes' object to str implicitly

Other than that, it builds fine and passes all tests (checked with python-3.3).

Can you please update tarball  at pypi site or (even better) include 'bindings' 
directory into compact-language-detector-0.1.tar.gz at code.google.com, so I 
can fetch it without mercurial installed.

Thanks!!

Original comment by trtrmi...@gmail.com on 9 Feb 2013 at 5:28

GoogleCodeExporter commented 9 years ago 
Hi, I fixed that exception in trying to print the error message when the CLD 
library wasn't installed, committed/pushed, and then pushed a new (0.2) release 
onto PyPI.  Can you try that out?  Thanks.

I'm haven't trouble remembering/figuring out how to do a source release of the 
full CLD + Python bindings here ...

Original comment by luc...@mikemccandless.com on 9 Feb 2013 at 11:53

GoogleCodeExporter commented 9 years ago 
With 0.2 I get this:

$ pip install --upgrade chromium-compact-language-detector==0.2
Downloading/unpacking chromium-compact-language-detector==0.2
  Running setup.py egg_info for package chromium-compact-language-detector
    `pkg-config --libs --cflags cld` returns in error:
    Package cld was not found in the pkg-config search path.
    Perhaps you should add the directory containing `cld.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'cld' found

    The `cld` C++ library is absent from this system. Please install it.
    Complete output from command python setup.py egg_info:
    `pkg-config --libs --cflags cld` returns in error:

Package cld was not found in the pkg-config search path.

Perhaps you should add the directory containing `cld.pc'

to the PKG_CONFIG_PATH environment variable

No package 'cld' found

The `cld` C++ library is absent from this system. Please install it.

Original comment by gunnlau...@gmail.com on 9 Feb 2013 at 3:45

GoogleCodeExporter commented 9 years ago 
Seems like the tarball is missing heaps of files, compared to the 0.031415 
release:

$ tar tvfz chromium_compact_language_detector-0.2.tar.gz 
drwxrwxr-x  0 mike   mike        0  9 feb 11:50 
chromium_compact_language_detector-0.2/
-rw-rw-r--  0 mike   mike      147 21 nóv 13:00 
chromium_compact_language_detector-0.2/AUTHORS
drwxrwxr-x  0 mike   mike        0  9 feb 11:50 
chromium_compact_language_detector-0.2/tests/
-rw-rw-r--  0 mike   mike    50185 21 maí  2012 
chromium_compact_language_detector-0.2/tests/testData.py
-rw-rw-r--  0 mike   mike    16824  8 feb 23:03 
chromium_compact_language_detector-0.2/tests/cld_test.py
-rw-rw-r--  0 mike   mike     1076 21 nóv 13:00 
chromium_compact_language_detector-0.2/INSTALL
-rw-rw-r--  0 mike   mike     1668 21 maí  2012 
chromium_compact_language_detector-0.2/COPYING
-rw-rw-r--  0 mike   mike      780  9 feb 11:50 
chromium_compact_language_detector-0.2/PKG-INFO
-rwxrwxr-x  0 mike   mike     3118  9 feb 11:36 
chromium_compact_language_detector-0.2/setup.py
-rw-rw-r--  0 mike   mike     3978  9 feb 11:44 
chromium_compact_language_detector-0.2/README
drwxrwxr-x  0 mike   mike        0  9 feb 11:50 
chromium_compact_language_detector-0.2/src/
-rw-rw-r--  0 mike   mike     2906 21 maí  2012 
chromium_compact_language_detector-0.2/src/cld_encodings.h
-rw-rw-r--  0 mike   mike    13154  8 feb 22:57 
chromium_compact_language_detector-0.2/src/pycldmodule.cc

versus the previous contents:

$ tar tvfz chromium_compact_language_detector-0.031415.tar.gz 
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/
-rw-rw-r--  0 mike   mike     9379 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/lang_enc.h
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/
-rw-rw-r--  0 mike   mike     4174 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/getonescr
iptspan.h
-rw-rw-r--  0 mike   mike    42928 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/cldutil.h
-rw-rw-r--  0 mike   mike     6271 23 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/compact_l
ang_det.h
-rw-rw-r--  0 mike   mike    31707 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/cldutil.c
c
-rw-rw-r--  0 mike   mike     2493 23 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/compact_l
ang_det.cc
-rw-rw-r--  0 mike   mike     2545 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/cldutil_d
bg.h
-rw-rw-r--  0 mike   mike     2311 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/letterscr
ipt_enum.h
-rw-rw-r--  0 mike   mike     2532 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/letterscr
ipt_enum.cc
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/
-rw-rw-r--  0 mike   mike      426 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_g
oogle.h
-rw-rw-r--  0 mike   mike      540 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_h
tmlutils.h
-rw-rw-r--  0 mike   mike      479 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_l
ogging.h
-rw-rw-r--  0 mike   mike     1807 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
nicodetext.h
-rw-rw-r--  0 mike   mike      752 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
tf8utils.h
-rw-rw-r--  0 mike   mike      737 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_s
trtoint.h
-rw-rw-r--  0 mike   mike      838 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_c
ommandlineflags.h
-rw-rw-r--  0 mike   mike     1072 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_h
tmlutils_windows.cc
-rw-rw-r--  0 mike   mike      741 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
tf.h
-rw-rw-r--  0 mike   mike     3340 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
nicodetext.cc
-rw-rw-r--  0 mike   mike      476 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
nilib.h
-rw-rw-r--  0 mike   mike      580 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
tf8utils_google3.cc
-rw-rw-r--  0 mike   mike      380 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_b
asictypes.h
-rw-rw-r--  0 mike   mike     1160 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
nilib_windows.cc
-rw-rw-r--  0 mike   mike     2618 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/norma
lizedunicodetext.h
-rw-rw-r--  0 mike   mike      567 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
tf8utils_windows.cc
-rw-rw-r--  0 mike   mike      569 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_m
acros.h
-rw-rw-r--  0 mike   mike     7248 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
tf8statetable.cc
-rw-rw-r--  0 mike   mike     4409 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/win/cld_u
tf8statetable.h
-rw-rw-r--  0 mike   mike     7235 23 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/compact_l
ang_det_impl.h
-rw-rw-r--  0 mike   mike    60108 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/utf8propl
etterscriptnum.h
-rw-rw-r--  0 mike   mike     3250 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/tote.h
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/
-rw-rw-r--  0 mike   mike  6024405 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_quadschrome.cc
-rw-rw-r--  0 mike   mike    20187 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/cld_generated_score_quadchrome_0406.cc
-rw-rw-r--  0 mike   mike     1420 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_cjkbis_0.cc
-rw-rw-r--  0 mike   mike     2497 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_ctjkvz_0.cc
-rw-rw-r--  0 mike   mike      436 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_meanscore.h
-rw-rw-r--  0 mike   mike    20102 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/cld_generated_score_deltaoctachrome_0406.cc
-rw-rw-r--  0 mike   mike   108957 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_deltaoctachrome.cc
-rw-rw-r--  0 mike   mike     1360 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_quads_0.cc
-rw-rw-r--  0 mike   mike   372282 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_ctjkvz.cc
-rw-rw-r--  0 mike   mike     1628 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/generated
/compact_lang_det_generated_longwords8_0.cc
-rw-rw-r--  0 mike   mike     4817 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/ext_lang_
enc.h
-rw-rw-r--  0 mike   mike    20895 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/getonescr
iptspan.cc
-rw-rw-r--  0 mike   mike   104705 24 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/compact_l
ang_det_impl.cc
-rw-rw-r--  0 mike   mike     2831 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/cldutil_d
bg_empty.cc
-rw-rw-r--  0 mike   mike     7857 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/tote.cc
-rw-rw-r--  0 mike   mike    57849 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/utf8scann
otjustletterspecial.h
-rw-rw-r--  0 mike   mike    56938 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/utf8propj
ustletter.h
-rw-rw-r--  0 mike   mike    18267 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/ext_lang_
enc.cc
-rw-rw-r--  0 mike   mike    50297 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/compact_lang_det/unittest_
data.h
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/internal/
-rw-rw-r--  0 mike   mike      364 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/internal/encodings.cc
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/proto/
-rw-rw-r--  0 mike   mike     7877 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/proto/encodings.pb.h
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/encodings/public/
-rw-rw-r--  0 mike   mike    10351 22 okt  2011 
chromium_compact_language_detector-0.031415/encodings/public/encodings.h
-rw-rw-r--  0 mike   mike     2906 24 okt  2011 
chromium_compact_language_detector-0.031415/cld_encodings.h
-rw-rw-r--  0 mike   mike      635 24 okt  2011 
chromium_compact_language_detector-0.031415/foo.py
-rw-rw-r--  0 mike   mike    50185 24 okt  2011 
chromium_compact_language_detector-0.031415/testData.py
-rw-rw-r--  0 mike   mike    12154 15 nóv  2011 
chromium_compact_language_detector-0.031415/pycldmodule.cc
-rw-rw-r--  0 mike   mike     3871 23 okt  2011 
chromium_compact_language_detector-0.031415/example.cc
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/languages/
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/languages/internal/
-rw-rw-r--  0 mike   mike    12770 24 okt  2011 
chromium_compact_language_detector-0.031415/languages/internal/languages.cc
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/languages/proto/
-rw-rw-r--  0 mike   mike     6032 22 okt  2011 
chromium_compact_language_detector-0.031415/languages/proto/languages.pb.h
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/languages/public/
-rw-rw-r--  0 mike   mike    13605 22 okt  2011 
chromium_compact_language_detector-0.031415/languages/public/languages.h
-rw-rw-r--  0 mike   mike      693  9 mar  2012 
chromium_compact_language_detector-0.031415/PKG-INFO
-rw-rw-r--  0 mike   mike     4949 24 okt  2011 
chromium_compact_language_detector-0.031415/README.txt
-rw-rw-r--  0 mike   mike     2508  9 mar  2012 
chromium_compact_language_detector-0.031415/setup.py
drwxrwxr-x  0 mike   mike        0  9 mar  2012 
chromium_compact_language_detector-0.031415/base/
-rw-rw-r--  0 mike   mike     8484 22 okt  2011 
chromium_compact_language_detector-0.031415/base/type_traits.h
-rw-rw-r--  0 mike   mike     1802 22 okt  2011 
chromium_compact_language_detector-0.031415/base/port.h
-rw-rw-r--  0 mike   mike     6403 22 okt  2011 
chromium_compact_language_detector-0.031415/base/casts.h
-rw-rw-r--  0 mike   mike     1234 22 okt  2011 
chromium_compact_language_detector-0.031415/base/log_severity.h
-rw-rw-r--  0 mike   mike     3040 22 okt  2011 
chromium_compact_language_detector-0.031415/base/template_util.h
-rw-rw-r--  0 mike   mike        0 22 okt  2011 
chromium_compact_language_detector-0.031415/base/stl_decl.h
-rw-rw-r--  0 mike   mike     1301 22 okt  2011 
chromium_compact_language_detector-0.031415/base/crash.h
-rw-rw-r--  0 mike   mike     4015 16 jan  2012 
chromium_compact_language_detector-0.031415/base/build_config.h
-rw-rw-r--  0 mike   mike    55765 22 okt  2011 
chromium_compact_language_detector-0.031415/base/logging.h
-rw-rw-r--  0 mike   mike    15551 22 okt  2011 
chromium_compact_language_detector-0.031415/base/dynamic_annotations.h
-rw-rw-r--  0 mike   mike    21457 22 okt  2011 
chromium_compact_language_detector-0.031415/base/commandlineflags.h
-rw-rw-r--  0 mike   mike    10234 22 okt  2011 
chromium_compact_language_detector-0.031415/base/macros.h
-rw-rw-r--  0 mike   mike      792 22 okt  2011 
chromium_compact_language_detector-0.031415/base/string_util.h
-rw-rw-r--  0 mike   mike     2861 22 okt  2011 
chromium_compact_language_detector-0.031415/base/stl_decl_msvc.h
-rw-rw-r--  0 mike   mike    13721 22 okt  2011 
chromium_compact_language_detector-0.031415/base/basictypes.h
-rw-rw-r--  0 mike   mike    15897 24 okt  2011 
chromium_compact_language_detector-0.031415/test.py

Original comment by gunnlau...@gmail.com on 9 Feb 2013 at 3:53

GoogleCodeExporter commented 9 years ago 
Is cld installed on this computer?

Hmm if you run:

  pkg-config --libs --cflags cld

, what does it say?

Original comment by luc...@mikemccandless.com on 9 Feb 2013 at 3:59

GoogleCodeExporter commented 9 years ago 
In 0.031415, had all sources (CLD + python bindings), but with newer versions 
you need to separately build/install cld (from http://code.google.com) and the 
Python bindings (from here).

But maybe we should go back to shipping all CLD sources via PyPI, like before 
...

Original comment by luc...@mikemccandless.com on 9 Feb 2013 at 4:03

GoogleCodeExporter commented 9 years ago 
It seems to work well with python-3 now, thank you very much!

Original comment by trtrmi...@gmail.com on 10 Feb 2013 at 7:40

GoogleCodeExporter commented 9 years ago 
Super, thanks for opening this issue!

Original comment by luc...@mikemccandless.com on 10 Feb 2013 at 10:59