mikemccand / luceneutil

Various utility scripts for running Lucene performance tests
Apache License 2.0
205 stars 115 forks source link

Add benchmarks for CombinedFieldsQuery #138

Closed jpountz closed 2 years ago

jpountz commented 3 years ago

It's so common to query multiple fields at once with the same query, we should have a benchmark for this case with the query that computes scores in a way that makes sense: CombinedFieldsQuery.

And hopefully we'll see a nice bump when LUCENE-10061 is implemented. :)

jtibshirani commented 2 years ago

Can this be closed now that https://github.com/mikemccand/luceneutil/pull/148 is merged?

mikemccand commented 2 years ago

I think almost! The hard part was already done in #148 (thank you @zacharymorn and @jpountz!). Maybe we could just add a few of these tasks into wikinightly.tasks, and tweak nightlyBench.py to add links to these new tasks when it writes the nightly index.html? Then we start tracking perf of this awesome query in nightlies ...

zacharymorn commented 2 years ago

I think almost! The hard part was already done in #148 (thank you @zacharymorn and @jpountz!). Maybe we could just add a few of these tasks into wikinightly.tasks, and tweak nightlyBench.py to add links to these new tasks when it writes the nightly index.html? Then we start tracking perf of this awesome query in nightlies ...

Oops didn't realize there's a github issue for this as well. I think adding it into nightly benchmark is a great suggestion! Let me take a look how it was done before, and will come up with something.