search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

migrate KeywordRepeatFilter to conditional tokenstreams [LUCENE-8308] #308

Open mikemccand opened 6 years ago

mikemccand commented 6 years ago

we should deprecate KeywordAttribute in favor of LUCENE-8273 which gives the analysis chain a real "if".

But this isn't straightforward unless we address the KeywordRepeatFilter which sends the token "both ways" down the branch condition. Maybe it can be handled as a subclass.

Legacy Jira details

LUCENE-8308 by Robert Muir (@rmuir) on May 11 2018

mikemccand commented 6 years ago

The other idea in mind being that we extend LUCENE-8273 to support "else" essentially. Then this repeater case would be more transparent/obvious, it fires for both the "if" and the "else".

[Legacy Jira: Robert Muir (@rmuir) on May 11 2018]

mikemccand commented 6 years ago

also maybe terminally deprecate KeywordRepeatFilter, i mean I doubt we can preserve compat here 100%: that is what major versions are for. If there was an "else" condition it would make it very easy on the user to migrate.

[Legacy Jira: Robert Muir (@rmuir) on May 11 2018]