search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Polygon tessellator can get into an infinite loop [LUCENE-8454] #453

Open mikemccand opened 5 years ago

mikemccand commented 5 years ago

I was trying to index some shapes using LatLonshape and for some complex shapes, there teselletor goes into an infinite loop. I am providing a test showing the problem.

 

@nknize, you might be interested on this.

Legacy Jira details

LUCENE-8454 by Ignacio Vera (@iverase) on Aug 13 2018, updated Sep 20 2018 Attachments: LUCENE-8454.patch

mikemccand commented 5 years ago

Thx @iverase I'll have a look.

[Legacy Jira: Nick Knize (@nknize) on Aug 13 2018]

mikemccand commented 5 years ago

Commit d494f6be13a585c273c6a3dabc76644f4d480c31 in lucene-solr's branch refs/heads/master from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d494f6b

LUCENE-8454: Fix incorrect vertex indexing and other computation errors in shape tessellation that would sometimes cause an infinite loop.

[Legacy Jira: ASF subversion and git services on Sep 19 2018]

mikemccand commented 5 years ago

Commit e1ceb630bd9d4831a2af6ba30115a27c16f1a4b0 in lucene-solr's branch refs/heads/branch_7_5 from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e1ceb63

LUCENE-8454: Fix incorrect vertex indexing and other computation errors in shape tessellation that would sometimes cause an infinite loop.

[Legacy Jira: ASF subversion and git services on Sep 19 2018]

mikemccand commented 5 years ago

Commit f54639d4a18bbca98c8853f7e5065a0a3752292c in lucene-solr's branch refs/heads/branch_7x from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f54639d

LUCENE-8454: Fix incorrect vertex indexing and other computation errors in shape tessellation that would sometimes cause an infinite loop.

[Legacy Jira: ASF subversion and git services on Sep 19 2018]

mikemccand commented 5 years ago

It seems the last change make random test unhappy, I reopen and set the test to awaitFix.

  07:45:12 [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestLatLonPolygonShapeQueries -Dtests.method=testRandomMedium -Dtests.seed=A4121D2A7CB14232 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=sv-SE -Dtests.timezone=America/Rainy_River -Dtests.asserts=true -Dtests.file.encoding=UTF-8*07:45:12* [junit4] FAILURE 5.96s J3 | TestLatLonPolygonShapeQueries.testRandomMedium <<<07:45:12 [junit4] > Throwable #1: java.lang.AssertionError: wrong hit (first of possibly more):07:45:12 [junit4] > FAIL: id=1734 should not match but did*07:45:12* [junit4] > relation=DISJOINT*07:45:12* [junit4] > query=LatLonShapeBoundingBoxQuery: field=shape:Rectangle(lat=-29.46555603761226 TO 0.0 lon=8.381903171539307E-8 TO 0.9999999403953552) docID=1696*07:45:12* [junit4] > shape=[-1.490648725633769E-132, 0.0] [90.0, 0.0] [90.0, 180.0] [-1.490648725633769E-132, 0.0] 07:45:12 [junit4] > deleted?=false rect=Rectangle(-29.46555603761226 TO 0.0 lon=8.381903171539307E-8 TO 0.9999999403953552)07:45:12 [junit4] > at __randomizedtesting.SeedInfo.seed([A4121D2A7CB14232:19CC2A823DD42154]:0)07:45:12 [junit4] > at org.apache.lucene.document.BaseLatLonShapeTestCase.verifyRandomBBoxQueries(BaseLatLonShapeTestCase.java:312)07:45:12 [junit4] > at org.apache.lucene.document.BaseLatLonShapeTestCase.verify(BaseLatLonShapeTestCase.java:197)07:45:12 [junit4] > at org.apache.lucene.document.BaseLatLonShapeTestCase.doTestRandom(BaseLatLonShapeTestCase.java:172)07:45:12 [junit4] > at org.apache.lucene.document.BaseLatLonShapeTestCase.testRandomMedium(BaseLatLonShapeTestCase.java:143)07:45:12 [junit4] > at java.lang.Thread.run(Thread.java:748)07:45:12 [junit4] 2> NOTE: leaving temporary files on disk at: /var/lib/jenkins/workspace/apache+lucene-solr+branch_7x/lucene/build/sandbox/test/J3/temp/lucene.document.TestLatLonPolygonShapeQueries_A4121D2A7CB14232-001

[Legacy Jira: Ignacio Vera (@iverase) on Sep 20 2018]

mikemccand commented 5 years ago

Commit eb0fcec50303e193339f49d8f15049551912b917 in lucene-solr's branch refs/heads/master from iverase https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eb0fcec

LUCENE-8454: Set test TestLatLonPolygonShapeQueries#testRandomMedium to AwaitFix

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit 26f6956cd3ebe71bfa04fa1d3e9fd22c9bc03559 in lucene-solr's branch refs/heads/branch_7x from iverase https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=26f6956

LUCENE-8454: Set test TestLatLonPolygonShapeQueries#testRandomMedium to AwaitFix

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit 7e56ce9bdfdab5597253434a37851ab859fa6df4 in lucene-solr's branch refs/heads/branch_7_5 from iverase https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7e56ce9

LUCENE-8454: Set test TestLatLonPolygonShapeQueries#testRandomMedium to AwaitFix

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit d7e97fb7f84d8613683a080610f177b7cae2b31a in lucene-solr's branch refs/heads/master from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d7e97fb

LUCENE-8454: Fix tessellator to use original polygon vertices.

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit 0c7543387572eff9a52e733d03f8d95e352be0f8 in lucene-solr's branch refs/heads/branch_7x from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0c75433

LUCENE-8454: Fix tessellator to use original polygon vertices.

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit 60e8ee717d9cd8d2425c100c21168d6a43b78516 in lucene-solr's branch refs/heads/branch_7_5 from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=60e8ee7

LUCENE-8454: Fix tessellator to use original polygon vertices.

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit d494f6be13a585c273c6a3dabc76644f4d480c31 in lucene-solr's branch refs/heads/jira/http2 from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d494f6b

LUCENE-8454: Fix incorrect vertex indexing and other computation errors in shape tessellation that would sometimes cause an infinite loop.

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit eb0fcec50303e193339f49d8f15049551912b917 in lucene-solr's branch refs/heads/jira/http2 from iverase https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eb0fcec

LUCENE-8454: Set test TestLatLonPolygonShapeQueries#testRandomMedium to AwaitFix

[Legacy Jira: ASF subversion and git services on Sep 20 2018]

mikemccand commented 5 years ago

Commit d7e97fb7f84d8613683a080610f177b7cae2b31a in lucene-solr's branch refs/heads/jira/http2 from @nknize https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d7e97fb

LUCENE-8454: Fix tessellator to use original polygon vertices.

[Legacy Jira: ASF subversion and git services on Sep 20 2018]