search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Move LatLonShape and XYShape out of sandbox [LUCENE-8621] #620

Open mikemccand opened 5 years ago

mikemccand commented 5 years ago

LatLonShape has matured a lot over the last months, I'd like to start thinking about moving it out of sandbox so that it doesn't stay there for too long like what happened to LatLonPoint. I am pretty happy with the current encoding. To my knowledge, we might just need to do a minor modification because of LUCENE-8620.

XYShape and foundation classes will also need to be refactored.

Legacy Jira details

LUCENE-8621 by Adrien Grand (@jpountz) on Dec 21 2018, updated Jan 22 2020 Linked issues:

mikemccand commented 5 years ago

+1

[Legacy Jira: Michael McCandless (@mikemccand) on Jan 01 2019]

mikemccand commented 5 years ago

+1

I can take this one. I vote:

  1. Move LatLonShape to core as a companion to LatLonPoint
  2. In a separate issue, refactor (or remove where appropriate) the two remaining classes ( GeoRelationUtils && MortonEncoder ) from the spatial module to either the core or spatial-extras module
  3. Remove the spatial module 

 We can do the refactor for 8.0 and keep it in sandbox for 7.7 leaving the 7.x line consistent?

 

[Legacy Jira: Nick Knize (@nknize) on Jan 02 2019]

mikemccand commented 5 years ago

BTW I already filed an issue to remove the spatial module and worked on it including a patch but @jpountz wasn't sure about that since it seemed LatLonShape would wind up there: https://issues.apache.org/jira/browse/LUCENE-8369?focusedCommentId=16525475&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16525475

While I'm a fan of having either no spatial or simple spatial in lucene-core, I'm also in favor of simplifying the user experience by reducing the number of places they will find spatial stuff. Balancing the two, and given the slippery slope of spatial already in lucene-core, I think it's best to remove the spatial module and put LatLonShape into core.

[Legacy Jira: David Smiley (@dsmiley) on Jan 02 2019]

mikemccand commented 5 years ago

Ah. Thank you  @dsmiley    I had forgotten about that issue.

+1 for the removal to be done for 8.0

[Legacy Jira: Nick Knize (@nknize) on Jan 03 2019]

mikemccand commented 5 years ago

Per LUCENE-8369 I'll take the task of refactoring LatLonShape, XYShape, and all foundation, utility, and query classes

[Legacy Jira: Nick Knize (@nknize) on Aug 14 2019]

mikemccand commented 4 years ago

Commit aad849bf87ab69c1bd0eb34518181e1f3c1c42f2 in lucene-solr's branch refs/heads/master from Nicholas Knize https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=aad849b

LUCENE-8621: Refactor LatLonShape, XYShape, and all query and utility classes from sandbox to core

[Legacy Jira: ASF subversion and git services on Jan 17 2020]

mikemccand commented 4 years ago

Commit bd1bf55b1875a223f9df9943545143af2291f099 in lucene-solr's branch refs/heads/branch_8x from Nicholas Knize https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=bd1bf55

LUCENE-8621: Refactor LatLonShape, XYShape, and all query and utility classes from sandbox to core

[Legacy Jira: ASF subversion and git services on Jan 22 2020]