search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Upgrade OpenNLP to 1.9.1 [LUCENE-8659] #658

Open mikemccand opened 5 years ago

mikemccand commented 5 years ago

Since Apache OpenNLP 1.9.1 has been released it would be nice to upgrade Lucene/Solr to use that.

Legacy Jira details

LUCENE-8659 by Tommaso Teofili (@tteofili) on Jan 26 2019, updated Dec 08 2021

mikemccand commented 5 years ago

created PR.

[Legacy Jira: Tommaso Teofili (@tteofili) on Jan 26 2019]

mikemccand commented 5 years ago

Commit 48073a9778730bed93cd9a33723a99679182ad0f in lucene-solr's branch refs/heads/master from Tommaso Teofili https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=48073a9

LUCENE-8659 - upgrade Lucene/Solr to use OpenNLP 1.9.1

[Legacy Jira: ASF subversion and git services on Jan 26 2019]

mikemccand commented 5 years ago

Commit debaa37501f84e9ae99dcc611d9a67286701e5aa in lucene-solr's branch refs/heads/master from Tommaso Teofili https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=debaa37

Merge pull request #548 from tteofili/LUCENE-8659

LUCENE-8659 - upgrade Lucene/Solr to use OpenNLP 1.9.1

[Legacy Jira: ASF subversion and git services on Jan 26 2019]

mikemccand commented 5 years ago

Commit debaa37501f84e9ae99dcc611d9a67286701e5aa in lucene-solr's branch refs/heads/master from Tommaso Teofili https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=debaa37

Merge pull request #548 from tteofili/LUCENE-8659

LUCENE-8659 - upgrade Lucene/Solr to use OpenNLP 1.9.1

[Legacy Jira: ASF subversion and git services on Jan 26 2019]

mikemccand commented 5 years ago

@teofili, you didn't remove the 1.9.0 jar's checksum and add the one for 1.9.1 (via ant jar-checksums), so Jenkins is complaining (from https://builds.apache.org/job/Lucene-Solr-SmokeRelease-master/1243/):

  [smoker] check-licenses:
  [smoker]      [echo] License check under: /x1/jenkins/jenkins-slave/workspace/Lucene-Solr-SmokeRelease-master/lucene/build/smokeTestRelease/tmp/unpack/lucene-9.0.0
  [smoker]  [licenses] MISSING sha1 checksum file for: /x1/jenkins/jenkins-slave/workspace/Lucene-Solr-SmokeRelease-master/lucene/build/smokeTestRelease/tmp/unpack/lucene-9.0.0/analysis/opennlp/lib/opennlp-tools-1.9.1.jar
  [smoker]  [licenses] EXPECTED sha1 checksum file : /x1/jenkins/jenkins-slave/workspace/Lucene-Solr-SmokeRelease-master/lucene/build/smokeTestRelease/tmp/unpack/lucene-9.0.0/licenses/opennlp-tools-1.9.1.jar.sha1
  [smoker]  [licenses] Scanned 36 JAR file(s) for licenses (in 0.40s.), 1 error(s).

Also:

[Legacy Jira: Steven Rowe on Jan 26 2019]

mikemccand commented 5 years ago

Commit 000785e68e69480743128b59c8838e0983e196c3 in lucene-solr's branch refs/heads/master from Tommaso Teofili https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=000785e

LUCENE-8659 - updated sha1 for OpenNLP dependency

[Legacy Jira: ASF subversion and git services on Jan 26 2019]

mikemccand commented 5 years ago

thanks ~steve_rowe, I've adjusted the checksums as per your previous comments. Yes, I'll backport this to 7x and 8x branches.

[Legacy Jira: Tommaso Teofili (@tteofili) on Jan 26 2019]

mikemccand commented 5 years ago

Commit be34f0837b59224f22922ea5050ea741c0577a4c in lucene-solr's branch refs/heads/branch_8x from Tommaso Teofili https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=be34f08

LUCENE-8659 - upgrade Lucene/Solr to use OpenNLP 1.9.1

(cherry picked from commit 48073a9778730bed93cd9a33723a99679182ad0f)

[Legacy Jira: ASF subversion and git services on Jan 28 2019]

mikemccand commented 5 years ago

Commit fbb28406fc6c3fba84ba38b76a274aa5eec72d16 in lucene-solr's branch refs/heads/branch_8x from Tommaso Teofili https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=fbb2840

LUCENE-8659 - updated sha1 for OpenNLP dependency

(cherry picked from commit 000785e68e69480743128b59c8838e0983e196c3)

[Legacy Jira: ASF subversion and git services on Jan 28 2019]