search

mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

Show SPI names only instead of class names in Luke Analysis tab [LUCENE-8874] #871

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

Each analyzer component factory now has an explicitly documented "NAME" static field (LUCENE-8778) to promote the proper use of (symbolic) SPI names. It would be better to get rid of all concrete factory class names from the Analysis tab UI, but instead show SPI names.

From implementation perspective, reflection tricks are needed to obtain the NAME field value without knowing the concrete classes (frameworks like Luke Analysis tab often don't know them). APIs to obtain the SPI name from a factory object might be needed for convenience and unified access to the names.

Legacy Jira details

LUCENE-8874 by Tomoko Uchida (@mocobeta) on Jun 23 2019, resolved Jun 30 2019 Attachments: LUCENE-8874.patch, Screenshot from 2019-06-30 13-15-40.png, Screenshot from 2019-06-30 13-15-57.png Linked issues:

mikemccand commented 5 years ago

Concrete class names appear in:

[Legacy Jira: Tomoko Uchida (@mocobeta) on Jun 23 2019]

mikemccand commented 5 years ago

Here is the patch: LUCENE-8874.patch

[Legacy Jira: Tomoko Uchida (@mocobeta) on Jun 30 2019]

mikemccand commented 5 years ago

Screenshots:

"Show analysis chain" dialog

Screenshot from 2019-06-30 13-15-40.png

 

"Step by Step" analysis results:

Screenshot from 2019-06-30 13-15-57.png

[Legacy Jira: Tomoko Uchida (@mocobeta) on Jun 30 2019]

mikemccand commented 5 years ago

Commit 299bfe55b3e40ca063ba08aec7efefc10007100d in lucene-solr's branch refs/heads/master from Tomoko Uchida https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=299bfe5

LUCENE-8874: Show SPI names instead of class names in Luke Analysis tab.

[Legacy Jira: ASF subversion and git services on Jun 30 2019]

mikemccand commented 5 years ago

Commit 2804d00137957dc27dce922103c6286bbc7a9eca in lucene-solr's branch refs/heads/branch_8x from Tomoko Uchida https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2804d00

LUCENE-8874: Show SPI names instead of class names in Luke Analysis tab.

[Legacy Jira: ASF subversion and git services on Jun 30 2019]

mikemccand commented 5 years ago

Closing after the 8.2.0 release

[Legacy Jira: Ignacio Vera (@iverase) on Jul 26 2019]