mikemccand / stargazers-migration-test

Testing Lucene's Jira -> GitHub issues migration
0 stars 0 forks source link

TestMutablePointsReaderUtils not doing what it is expected [LUCENE-8886] #883

Closed mikemccand closed 5 years ago

mikemccand commented 5 years ago

The TestMutablePointsReaderUtils is actually not doing what it is expected. The problem is that we are constructing Point objects but not copying the bytes provided so is always working with arrays with 0 values.


Legacy Jira details

LUCENE-8886 by Ignacio Vera (@iverase) on Jun 26 2019, resolved Jun 27 2019 Attachments: LUCENE-8886.patch

mikemccand commented 5 years ago
-1 overall
Vote Subsystem Runtime Comment
Prechecks
+1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
master Compile Tests
+1 compile 0m 49s master passed
Patch Compile Tests
+1 compile 0m 41s the patch passed
+1 javac 0m 41s the patch passed
+1 Release audit (RAT) 0m 41s the patch passed
-1 Check forbidden APIs 0m 41s Check forbidden APIs check-forbidden-apis failed
-1 Validate source patterns 0m 41s Check forbidden APIs check-forbidden-apis failed
Other Tests
+1 unit 17m 41s core in the patch passed.
20m 11s
Subsystem Report/Notes
JIRA Issue LUCENE-8886
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12972990/LUCENE-8886.patch
Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns
uname Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / 7032176
ant version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018
Default Java LTS
Check forbidden APIs https://builds.apache.org/job/PreCommit-LUCENE-Build/192/artifact/out/patch-check-forbidden-apis-lucene.txt
Validate source patterns https://builds.apache.org/job/PreCommit-LUCENE-Build/192/artifact/out/patch-check-forbidden-apis-lucene.txt
Test Results https://builds.apache.org/job/PreCommit-LUCENE-Build/192/testReport/
modules C: lucene/core U: lucene/core
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/192/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

[Legacy Jira: Lucene/Solr QA on Jun 27 2019]

mikemccand commented 5 years ago

+1

[Legacy Jira: Adrien Grand (@jpountz) on Jun 27 2019]

mikemccand commented 5 years ago

Commit 754ce1f437c3e6c9b40a273bad9d86f3a2f3d5e6 in lucene-solr's branch refs/heads/master from Ignacio Vera https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=754ce1f

LUCENE-8886: Fix TestMutablePointsReaderUtils tests

[Legacy Jira: ASF subversion and git services on Jun 27 2019]

mikemccand commented 5 years ago

Commit 4e58515b0c6aa297be2416c5e5d70e9eda4fb1db in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4e58515

LUCENE-8886: Fix TestMutablePointsReaderUtils tests

[Legacy Jira: ASF subversion and git services on Jun 27 2019]

mikemccand commented 5 years ago

Closing after the 8.2.0 release

[Legacy Jira: Ignacio Vera (@iverase) on Jul 26 2019]